Closed Bug 1022970 Opened 6 years ago Closed 6 years ago

Switch from UNIFIED_SOURCES back to SOURCES in mozilla::pkix, security/certVerifier, and security/manager/ssl/src

Categories

(Core :: Security: PSM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(2 files, 1 obsolete file)

A couple of times now I've been burned during landing changes that could have been detected easier if we weren't using UNIFIED_SOURCES in mozilla::pkix. I'm planning to do a lot of refactoring in mozilla::pkix in a the next few weeks and I'd like the build to be more predictable for now. Once the refactorings are over, and we're not making so many changes to mozilla::pkix, we can switch back to UNIFIED_SOURCES. mozilla::pkix is very small and this change should have a very small effect on build time anyway.
Attachment #8437307 - Flags: review?(dkeeler)
Assignee: nobody → brian
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla33
Comment on attachment 8437307 [details]
switch-to-non-unified-sources.patch

Ok. Do you have a bug filed for reversing this? It would be nice to reference that in a comment with these changes.
Attachment #8437307 - Flags: review?(dkeeler) → review+
Summary: Switch from UNIFIED_SOURCES back to SOURCES in mozilla::pkix → Switch from UNIFIED_SOURCES back to SOURCES in mozilla::pkix and CertVerifier
Summary: Switch from UNIFIED_SOURCES back to SOURCES in mozilla::pkix and CertVerifier → Switch from UNIFIED_SOURCES back to SOURCES in mozilla::pkix, security/certVerifier, and security/manager/ssl/src
I verified that this builds successfully using tryserver. I have patches pending that depend on all of these changes.
Attachment #8441127 - Attachment is obsolete: true
Attachment #8441127 - Flags: review?(dkeeler)
Attachment #8441174 - Flags: review?(dkeeler)
Comment on attachment 8441174 [details] [diff] [review]
less-UNIFIED_SOURCES.patch

Review of attachment 8441174 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine. Again, I would appreciate you filing a bug on reverting this change when you're done with whatever makes it difficult to develop with UNIFIED_SOURCES.
Attachment #8441174 - Flags: review?(dkeeler) → review+
Thanks for the reviews! I filed the follow-up bug, which is marked as depending on this bug.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e74c19c18f01
https://hg.mozilla.org/mozilla-central/rev/e74c19c18f01
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.