1022970 - Switch from UNIFIED_SOURCES back to SOURCES in mozilla::pkix, security/certVerifier, and security/manager/ssl/src

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: switch-to-non-unified-sources.patch

A couple of times now I've been burned during landing changes that could have been detected easier if we weren't using UNIFIED_SOURCES in mozilla::pkix. I'm planning to do a lot of refactoring in mozilla::pkix in a the next few weeks and I'd like the build to be more predictable for now. Once the refactorings are over, and we're not making so many changes to mozilla::pkix, we can switch back to UNIFIED_SOURCES. mozilla::pkix is very small and this change should have a very small effect on build time anyway.

Comment 1

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8437307 [details]
switch-to-non-unified-sources.patch

Ok. Do you have a bug filed for reversing this? It would be nice to reference that in a comment with these changes.

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: switch-CertVerifier-to-SOURCES.patch

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: less-UNIFIED_SOURCES.patch

I verified that this builds successfully using tryserver. I have patches pending that depend on all of these changes.

Comment 4

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8441174 [details] [diff] [review]
less-UNIFIED_SOURCES.patch

Review of attachment 8441174 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine. Again, I would appreciate you filing a bug on reverting this change when you're done with whatever makes it difficult to develop with UNIFIED_SOURCES.

Comment 5

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Thanks for the reviews! I filed the follow-up bug, which is marked as depending on this bug.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e74c19c18f01

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e74c19c18f01