1027234 - Switch back to UNIFIED_SOURCES in security/pkix

Status: RESOLVED WONTFIX

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #1022970 +++

After the refactorings we are doing are complete, let's switch back to UNIFIED_SOURCES by reverting the change from bug 1022970.

Comment 1

[(no longer active)]

Brian, can we now switch back to use unified builds in these directories?  Thanks!

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #1)
> Brian, can we now switch back to use unified builds in these directories? 
> Thanks!

Is if fine with me to switch it back.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Brian Smith (:briansmith, :bsmith, use NEEDINFO?) from comment #2)
> > Brian, can we now switch back to use unified builds in these directories? 
> > Thanks!
> 
> Is if fine with me to switch it back.

Actually, I would prefer if we could still avoid using UNIFIED_SOURCES in security/pkix/*. I don't think security/pkix has a significant impact on build time. I still am writing the majority of patches for mozilla::pkix and I do development on mozilla::on a separate codebase with a separate build system. Thus, the difference between UNIFIED_SOURCES or not impacts security/pkix/* more than other parts.

However, I don't have any issues with security/certverifier or security/manager/* switching back to UNIFIED_SOURCES.

Comment 4

[(no longer active)]

The issue is that these little bits and pieces add up when building the entire tree...  But if you're actively refactoring things in this code it's OK to leave this non-unified for now, but I would like to switch it back at some point to get back the build speed improvements.

I filed bug 1061942 for security/certverifier and security/manager.

Comment 5

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #4)
> The issue is that these little bits and pieces add up when building the
> entire tree...  But if you're actively refactoring things in this code it's
> OK to leave this non-unified for now, but I would like to switch it back at
> some point to get back the build speed improvements.

security/pkix is very unusual in that it is actually optimized to be small and have very few dependencies, so I don't think there would be any substantial benefit to UNIFIED_SOURCES for it, especially after we remove the unnecessary NSS/NSPR dependencies, which I'm currently working on. Also, it is important (to me, anyway) that it be easy to build independently from the Mozilla build system. Thus, I would like to WONTFIX this bug.

Regardless, right now the lack of UNIFIED_SOURCES for mozilla::pkix is particular useful because it helps prevent accidental NSPR/NSS dependencies from being added to the files that no longer allowed to depend on NSS and NSPR, which will soon be all but two.

Comment 6

[(no longer active)]

OK, fair enough!