1023019 - Make the canvas graphs plot the data underneath the selection, markers and cursor

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Victor Porof [:vporof][:vp]]

Noticed this while working on bug 1007460. We need to draw the graph underneath the selection, not on top of it. We're getting away with it with the line graph (bug 1007202) because the fill color is almost transparent.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8437388 [details] [diff] [review]
v1

Review of attachment 8437388 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/Graphs.jsm
@@ +500,5 @@
>  
>      let ctx = this._ctx;
>      ctx.clearRect(0, 0, this._width, this._height);
>  
> +    // Draw the grpah underneath the cursor and selection.

s/grpah/graph

Comment 3

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/28fd6610755d

Comment 4

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/be06207ef471

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/be06207ef471
https://hg.mozilla.org/mozilla-central/rev/28fd6610755d