Closed
Bug 1023019
Opened 10 years ago
Closed 10 years ago
Make the canvas graphs plot the data underneath the selection, markers and cursor
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: vporof, Assigned: vporof)
References
Details
Attachments
(1 file)
1.32 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
Noticed this while working on bug 1007460. We need to draw the graph underneath the selection, not on top of it. We're getting away with it with the line graph (bug 1007202) because the fill color is almost transparent.
Assignee | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8437388 [details] [diff] [review] v1 Review of attachment 8437388 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/shared/widgets/Graphs.jsm @@ +500,5 @@ > > let ctx = this._ctx; > ctx.clearRect(0, 0, this._width, this._height); > > + // Draw the grpah underneath the cursor and selection. s/grpah/graph
Attachment #8437388 -
Flags: review?(pbrosset) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/28fd6610755d
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/be06207ef471
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/be06207ef471 https://hg.mozilla.org/mozilla-central/rev/28fd6610755d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•