Make the canvas graphs plot the data underneath the selection, markers and cursor

RESOLVED FIXED in Firefox 33

Status

()

Firefox
Developer Tools: Performance Tools (Profiler/Timeline)
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Firefox 33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Noticed this while working on bug 1007460. We need to draw the graph underneath the selection, not on top of it. We're getting away with it with the line graph (bug 1007202) because the fill color is almost transparent.
(Assignee)

Comment 1

4 years ago
Created attachment 8437388 [details] [diff] [review]
v1
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8437388 - Flags: review?(pbrosset)
(Assignee)

Updated

4 years ago
Blocks: 1007460
Comment on attachment 8437388 [details] [diff] [review]
v1

Review of attachment 8437388 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/Graphs.jsm
@@ +500,5 @@
>  
>      let ctx = this._ctx;
>      ctx.clearRect(0, 0, this._width, this._height);
>  
> +    // Draw the grpah underneath the cursor and selection.

s/grpah/graph
Attachment #8437388 - Flags: review?(pbrosset) → review+
https://hg.mozilla.org/mozilla-central/rev/be06207ef471
https://hg.mozilla.org/mozilla-central/rev/28fd6610755d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
You need to log in before you can comment on or make changes to this bug.