1023208 - [v2.0][v2.1] Fix test_marketplace_launch failure

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Robert Chira [:RobertC]]

The test is failing because the marketplace icon is not fully visible.

Comment 1

[Robert Chira [:RobertC]]

Attachment: Pull request v2.0

Added a scroll into view for the marketplace icon.

Comment 2

[Robert Chira [:RobertC]]

Attachment: Pull request v2.1

Uplift from Pull request v2.0

Comment 3

[Florin Strugariu [:Bebe]]

Comment on attachment 8437628 [details] [review]
Pull request v2.1

The travis fail has nothing to do with the pull

Comment 4

[Florin Strugariu [:Bebe]]

Comment on attachment 8437628 [details] [review]
Pull request v2.1

In the second look this is a hack as it changes the tap icon functionality 
So we need to remove it in the future.

Is there a outstanding bug in Marionette for this issue?


Zac are we OK with adding this?

Comment 5

[Zac C (:zac)]

I think the underlying Marionette issue is:
https://bugzilla.mozilla.org/show_bug.cgi?id=1020910

I suppose that it thinks all icons are displayed and hence it doesn't try to scroll to it.

Comment 6

[Zac C (:zac)]

Robert, the bug that is causing this is:
https://bugzilla.mozilla.org/show_bug.cgi?id=937053

Can you update the pull requests?

Comment 7

[Zac C (:zac)]

Comment on attachment 8437628 [details] [review]
Pull request v2.1

r-, add the comment citing bug 937053

Comment 8

[Robert Chira [:RobertC]]

Comment on attachment 8437628 [details] [review]
Pull request v2.1

Added a TODO comment above the scroll hack.

Comment 9

[Zac C (:zac)]

Comment on attachment 8437625 [details] [review]
Pull request v2.0

r+

Comment 10

[Zac C (:zac)]

Comment on attachment 8437628 [details] [review]
Pull request v2.1

r+

Comment 11

[Zac C (:zac)]

master:
https://github.com/mozilla-b2g/gaia/commit/7b68726ed274a59aa31202eb406abb246b527510
2.0:
https://github.com/mozilla-b2g/gaia/commit/6025d6432dfec4fd78286acce43d3882fca888e5