Closed Bug 1023464 Opened 8 years ago Closed 8 years ago

Add support for the --setpref argument for mach reftest

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla33

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
runreftest.py supports a --setpref argument (added by bug 524489), and today I wanted to use it with mach in order to test BasicCompositor, but it didn't work. This patch adds support for it.

It's used like this:

mach reftest --setpref layers.acceleration.disabled=true --setpref layers.offmainthreadcomposition.force-basic=true layout/reftests/bugs/reftest.list
Attachment #8437852 - Flags: review?(gps)
Comment on attachment 8437852 [details] [diff] [review]
v1

Review of attachment 8437852 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome.
Attachment #8437852 - Flags: review?(gps) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae9b6e0ddc00
Assignee: nobody → mstange
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/ae9b6e0ddc00
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.