only initialize platform accessibility in the main process

RESOLVED FIXED in Firefox 40

Status

()

Core
Disability Access APIs
RESOLVED FIXED
4 years ago
3 months ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

(Blocks: 1 bug)

unspecified
mozilla40
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8437908 [details] [diff] [review]
only initialize platform accessibility in the main process

Since platform accessibility software only interacts with the main
process there's no reason to do platform specific things in the content
processes.  Eventually we should also be able to only create generic
accessibles that don't use the platform wrapper classes, but that will
take more work so we'll keep creating them in the content processes for
now.
Attachment #8437908 - Flags: review?(dbolter)
Blocks: 646596
Attachment #8437908 - Flags: review?(dbolter) → review+

Comment 2

4 years ago
Comment on attachment 8437908 [details] [diff] [review]
only initialize platform accessibility in the main process

Review of attachment 8437908 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/nsAccessibilityService.cpp
@@ +1090,5 @@
>  #ifdef A11Y_LOG
>    logging::CheckEnv();
>  #endif
>  
> +  if (XRE_GetProcessType() == GeckoProcessType_Default)

it'd be nice to have IsDefaultProces() helper
(In reply to alexander :surkov from comment #2)
> Comment on attachment 8437908 [details] [diff] [review]
> only initialize platform accessibility in the main process
> 
> Review of attachment 8437908 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/src/base/nsAccessibilityService.cpp
> @@ +1090,5 @@
> >  #ifdef A11Y_LOG
> >    logging::CheckEnv();
> >  #endif
> >  
> > +  if (XRE_GetProcessType() == GeckoProcessType_Default)
> 
> it'd be nice to have IsDefaultProces() helper

I considered that too but I sort of like it raw.
(Assignee)

Comment 4

4 years ago
(In reply to alexander :surkov from comment #2)
> Comment on attachment 8437908 [details] [diff] [review]
> only initialize platform accessibility in the main process
> 
> Review of attachment 8437908 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/src/base/nsAccessibilityService.cpp
> @@ +1090,5 @@
> >  #ifdef A11Y_LOG
> >    logging::CheckEnv();
> >  #endif
> >  
> > +  if (XRE_GetProcessType() == GeckoProcessType_Default)
> 
> it'd be nice to have IsDefaultProces() helper

I'd say IsMainProcess or something would make more sense, but I'd say it makes sense to add such a function to nsXULAppAPI.h.  If you want to add such a function there fine, but I don't really think its worth the time.

Comment 5

4 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #4)

> > > +  if (XRE_GetProcessType() == GeckoProcessType_Default)
> > 
> > it'd be nice to have IsDefaultProces() helper
> 
> I'd say IsMainProcess or something would make more sense,

this one is also good with me

> but I'd say it
> makes sense to add such a function to nsXULAppAPI.h.  

sure, I didn't mean to put it into a11y :)

> If you want to add
> such a function there fine, but I don't really think its worth the time.

just syntax sugar, short and nice, we may have gfb
Blocks: 1029143
No longer blocks: 646596

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/27de813b3f79
https://hg.mozilla.org/mozilla-central/rev/27de813b3f79
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee: nobody → tbsaunde+mozbugs

Updated

3 months ago
Blocks: 1401392
You need to log in before you can comment on or make changes to this bug.