Closed
Bug 1023509
Opened 10 years ago
Closed 9 years ago
only initialize platform accessibility in the main process
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
Details
Attachments
(1 file)
2.57 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Since platform accessibility software only interacts with the main process there's no reason to do platform specific things in the content processes. Eventually we should also be able to only create generic accessibles that don't use the platform wrapper classes, but that will take more work so we'll keep creating them in the content processes for now.
Attachment #8437908 -
Flags: review?(dbolter)
Updated•10 years ago
|
Attachment #8437908 -
Flags: review?(dbolter) → review+
Comment 2•10 years ago
|
||
Comment on attachment 8437908 [details] [diff] [review] only initialize platform accessibility in the main process Review of attachment 8437908 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/src/base/nsAccessibilityService.cpp @@ +1090,5 @@ > #ifdef A11Y_LOG > logging::CheckEnv(); > #endif > > + if (XRE_GetProcessType() == GeckoProcessType_Default) it'd be nice to have IsDefaultProces() helper
Comment 3•10 years ago
|
||
(In reply to alexander :surkov from comment #2) > Comment on attachment 8437908 [details] [diff] [review] > only initialize platform accessibility in the main process > > Review of attachment 8437908 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: accessible/src/base/nsAccessibilityService.cpp > @@ +1090,5 @@ > > #ifdef A11Y_LOG > > logging::CheckEnv(); > > #endif > > > > + if (XRE_GetProcessType() == GeckoProcessType_Default) > > it'd be nice to have IsDefaultProces() helper I considered that too but I sort of like it raw.
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to alexander :surkov from comment #2) > Comment on attachment 8437908 [details] [diff] [review] > only initialize platform accessibility in the main process > > Review of attachment 8437908 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: accessible/src/base/nsAccessibilityService.cpp > @@ +1090,5 @@ > > #ifdef A11Y_LOG > > logging::CheckEnv(); > > #endif > > > > + if (XRE_GetProcessType() == GeckoProcessType_Default) > > it'd be nice to have IsDefaultProces() helper I'd say IsMainProcess or something would make more sense, but I'd say it makes sense to add such a function to nsXULAppAPI.h. If you want to add such a function there fine, but I don't really think its worth the time.
Comment 5•10 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #4) > > > + if (XRE_GetProcessType() == GeckoProcessType_Default) > > > > it'd be nice to have IsDefaultProces() helper > > I'd say IsMainProcess or something would make more sense, this one is also good with me > but I'd say it > makes sense to add such a function to nsXULAppAPI.h. sure, I didn't mean to put it into a11y :) > If you want to add > such a function there fine, but I don't really think its worth the time. just syntax sugar, short and nice, we may have gfb
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/27de813b3f79
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•9 years ago
|
Assignee: nobody → tbsaunde+mozbugs
You need to log in
before you can comment on or make changes to this bug.
Description
•