Closed
Bug 1023631
Opened 11 years ago
Closed 11 years ago
[collections] Smart collections should still display even if we cannot fetch the background image.
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g-v2.0 verified, b2g-v2.1 verified)
VERIFIED
FIXED
2.0 S4 (20june)
People
(Reporter: jlal, Assigned: kgrandon)
References
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
|
46 bytes,
text/x-github-pull-request
|
jlal
:
review+
bajaj
:
approval-gaia-v2.0+
|
Details | Review |
|
1.61 MB,
video/mp4
|
Details |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Needs a test if possible.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8438095 [details] [review]
Github pull request
Ok - let's unblock testing then, and we'll work on integration tests.
Attachment #8438095 -
Flags: review?(jlal)
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8438095 [details] [review]
Github pull request
https://github.com/mozilla-b2g/gaia/commit/adf6d4f66497c88d68a9e5509d740eef182af4f8
Attachment #8438095 -
Flags: review?(jlal) → review+
|
|
Reporter | |
Comment 4•11 years ago
|
||
This is a sorta-hack we should still have a default background or something in the error case but at least we can _see_ the thing now.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 8438095 [details] [review]
Github pull request
This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.
Attachment #8438095 -
Flags: approval-gaia-v2.0?(bbajaj)
|
||
Updated•11 years ago
|
Attachment #8438095 -
Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
|
|
||
Comment 6•11 years ago
|
||
Johan, lets verify this post landing.
Flags: needinfo?(jlorenzo)
Keywords: verifyme
|
|
Assignee | |
Comment 7•11 years ago
|
||
status-b2g-v2.0:
--- → fixed
status-b2g-v2.1:
--- → fixed
|
||
Comment 8•11 years ago
|
||
Verified on master with a standard & a custom (unknown English word) Smart Collections.
|
||
Updated•11 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S4 (20june)
|
||
Comment 9•11 years ago
|
||
James,
Could you please provide the detailed reproduce steps for me to verify this bug?
Thank you very much!
Flags: needinfo?(jlal)
|
|
Assignee | |
Comment 10•11 years ago
|
||
For this one I think if you can start the phone without an internet connection or sim card and see smart collections, then it's working.
Flags: needinfo?(jlal)
|
|
||
Comment 11•11 years ago
|
||
According to comment 10, this issue has been verified successfully on Flame 2.0 & 2.1.
Issue steps:
1.Restart the phone without an internet connection or sim card.
2. View the smart collections.
**Smart collections are displayed on the Homescreen.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10
Flame v2.0 version:
Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID 20141127000203
Version 32.0
Flame v2.1 version:
Gaia-Rev 5372b675e018b6aac97d95ff5db8d4bd16addb9b
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b
Build-ID 20141127001201
Version 34.0
|
|
||
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•