1023312 - [Vertical homescreen] Smart collection viewing fails on the flame (and similar sized devices) because e.me server fails to return background.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Zac C (:zac)]

Attachment: 2014-06-10-15-59-56.png

STR:
1. Connect to wifi network
2. Long press on homescreen
3. Choose 'Add Smart Collections'
4. Select a collection eg Social
5. Tap OK
6. On homescreen, scroll to the Collection
7. Tap the collection

Error alert is shown

Comment 1

[Zac C (:zac)]

Attachment: collection-error-logcat.txt

Logcat of the failure

Comment 2

[Zac C (:zac)]

Build under test:
Gaia      f42ebc93554979501d3ac52bcf9e69cb4b310a4f
Gecko     https://hg.mozilla.org/mozilla-central/rev/9dc0ffca10f4
BuildID   20140610040208
Version   33.0a1
ro.build.version.incremental=eng.cltbld.20140605.031251
ro.build.date=Thu Jun  5 03:13:01 EDT 2014

Device: Flame

Comment 3

[James Lal [:lightsofapollo]]

I am hitting this all the time too!

Comment 4

[James Lal [:lightsofapollo]]

The root of this problem is the e.me server requests a background image based on the size of the screen of the device... On the flame these values are:

  width: 480
  height: 853.5

By hard coding the values (https://github.com/mozilla-b2g/gaia/blob/master/shared/js/everythingme/api.js#L136) to 

  width: 360
  height: 480

I can view collections (with a nice background image)... This is in fact  two bugs... The first being that we should not fail to show collections without a background and second that the e.me server would ideally not fail when requesting an icon without a known size.

@Amir, @Ran Can you help us fix the server side.

Comment 5

[Jason Smith [:jsmith]]

Calling this is a regression since this worked correctly in the old homescreen.

Comment 6

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Pull request

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

Bug 1 (don't fail to show collections without a background) - Bug 1020961
Bus 2 - attachment 8438391 [details] [review]

Comment 8

[Kevin Grandon :kgrandon]

I'm seeing a background image after testing, there's an R+, and travis erros look unrelated. Going to land.

https://github.com/mozilla-b2g/gaia/commit/b36d7d43f9c610def965ed7dba88219101aee073

Comment 9

[Kevin Grandon :kgrandon]

Uplifted: https://github.com/mozilla-b2g/gaia/commit/ffbc0d0f515a7812007de2bf5188cd3f69f2e403

Comment 10

[Johan Lorenzo [:jlorenzo]]

Verified on master.

Comment 11

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 &2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141127000203
Version         32.0

Flame v2.1 version:
Gaia-Rev        5372b675e018b6aac97d95ff5db8d4bd16addb9b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b
Build-ID        20141127001201
Version         34.0