1023664 - [User story] Add recurring events to the calendar

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Comment 1

[Harly Hsu[:harly]]

Attachment: [2.1 Calendar] Recurring Meeting Invites_v1.0.pdf

Comment 2

[Kai-Chih Hu [:khu]]

Candice, did you assign incorrect version in the target milestone? Did you mean 2.1 S1 rather than 2.0 S1? Thanks.

Comment 3

[Candice Serran (:cserran)]

Yep...my mistake..updated!

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22582

Hey Miller! Looking for some preliminary feedback here. The patch doesn't even conceptually do all of the things we need for it to do yet, but it does move things around quite a bit. I've gotten rid of the "Local" and "Caldav" providers and the distinction between them. It's quite a bit less code (about 500 LOC compared to 1000 before). Provider is no longer an instantiable class; I don't know why we would ever have multiple running.

Now even local events talk to the caldav worker to do ical create/update/delete stuff. I send along a boolean flag with local operations that tells the worker not to sync local events to a remote server.

I'm also going to write a database migration to take all of the existing 2.0 users' local events and create ical components for them.

Anyway let me know what you think about the general architecture of the changeset and we'll go from there.

/cc lightsofapollo

Comment 6

[Edward Chen[:edchen]]

Test cases: https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-tag=2971

Comment 7

[Kai-Chih Hu [:khu]]

Use feature-b2g:2.2? rather than just 2.2.

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23423/files

I need to start breaking my patch and its various refactorings off into bite-sized, reviewable chunks. Let's try to get the refactoring bits in this week before branching so that the 2.1 codebase looks somewhat similar to the 2.2 codebase.

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23432

This one cleans up the dependency situation for top-level js

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/2991746d61bae865f6e0c0dfacda07ae3c2f2fbd landed module refactoring parts

Comment 11

[Ryan VanderMeulen [:RyanVM]]

(In reply to Gareth Aye [:gaye] from comment #10)
> https://github.com/mozilla-b2g/gaia/commit/
> 2991746d61bae865f6e0c0dfacda07ae3c2f2fbd landed module refactoring parts

Reverted for causing the exact same Gaia unit test failures that were also apparent in your Gaia-Try run.....

Master: https://github.com/mozilla-b2g/gaia/commit/008026e932b64b4a70b9931c3da96986583bc8d4

Comment 12

[Kevin Grandon :kgrandon]

I've reverted this and re-landed because it did not have the proper bug # or reviewer in the new commit message. This would make investigation in the future much harder. This is under the assumption that commit 6bed81614b5522d84c91d6b607e3d2ef0ee3229b was tracked against this bug.

Revert: https://github.com/mozilla-b2g/gaia/commit/d9c0e351f1946396a31cc40bf18fd24291084ca5
Re-land: https://github.com/mozilla-b2g/gaia/commit/8485bd2d8a2e94f013385a172501a153273e8b69

Comment 13

[Miller Medeiros [:millermedeiros]]

Gareth, I just realized that one change is throwing a JS Error: E/GeckoConsole( 1554): [JavaScript Error: "TypeError: callback is not a function" {file: "app://calendar.gaiamobile.org/js/views/settings.js" line: 277}] - we never have pass a callback to this function, so let's remove the callback logic.

Comment 14

[Johannes Raggam]

Can't see how far your are with supporting recurring events, but for the CMS Plone we have developed a JavaScript recurrence widget some years ago.

It's quite flexible - it supports different form templates (daily, weekly, monthly, etc.) + the addition and removal of individual dates. It creates an RFC5545/icalendar compatible string.

https://github.com/collective/jquery.recurrenceinput.js

Here's a screenshot: https://github.com/collective/jquery.recurrenceinput.js/blob/master/Screenshot.png

There is the idea to rewrite it and get rid of some ancient JS libs (jquerytools, jquery-templ), but the general business logic could be helpful for FirefoxOS too.

Are there any chances for a joint effort? Or do you have already a working implementation of an recurrence widget? If so, where? I'd love to see, if we can re-use parts of it :)

Comment 15

[Stephany Wilkes]

This is in for 2.2. Kevin, please let me know if the patches are good to start 2.2 sprint #1 with.

Comment 16

[Kevin Grandon :kgrandon]

(In reply to Stephany Wilkes from comment #15)
> This is in for 2.2. Kevin, please let me know if the patches are good to
> start 2.2 sprint #1 with.

Did you mean to ping me on this bug? I would defer this to the patch author/bug assignee.

Comment 17

[Jean-Baptiste (djib)]

Isn't https://bugzilla.mozilla.org/show_bug.cgi?id=931983 a duplicate of this bug (or the other way around actually, but it seems this one is way more advanced).

Comment 19

[fagelot]

Hi Guys,
Don't know if the following remark is in the right section but I'd like to provide already my apologies if it's not.
As it's regarding the calendar I would like to share my experience and my expectation here.

So I have to configure my calendar app within FXOS to sync with my Google Calendar and it seems working fine until I stated that there is no notification in my notification area for any events which will occur during the day or the next days. It seems just opening the calendar app in background within the task list.

Any idea on what's happening ?

Thanks