1024397 - [Vertical] Activity: When a value selector is shown, press home button won't blur it

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Amir Nissim (:amirn)]

see :alive comment here https://bugzilla.mozilla.org/show_bug.cgi?id=1021270#c19

STR:
1. long tap homescreen and choose `add collection`
2. wait for the suggestions list to load
3. tap the homebutton

expected:
the activity is closed, list is hidden, back to homescreen

observed:
list is not hidden

Comment 1

[Amir Nissim (:amirn)]

Kevin, IMO this one is a blocker.

Comment 2

[Jason Smith [:jsmith]]

A video would help clarify the bug here.

Comment 3

[Amir Nissim (:amirn)]

Attachment: video of the bug

Comment 4

[Kevin Grandon :kgrandon]

Is it a regression of that bug, or is it because we made the home button go to activities first? I wonder if we can just listen for hashchange and close ourself.

Comment 5

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

QA Wanted request was satisfied by reporter

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Kevin Grandon :kgrandon from comment #4)
> Is it a regression of that bug, or is it because we made the home button go
> to activities first? I wonder if we can just listen for hashchange and close
> ourself.

Maybe not. The problem is the value selector is first seen on an activity called by homescreen.
Home button will kill the activity but it seems the focus doesn't change to trigger the value selector to disappear.

Comment 7

[Kevin Grandon :kgrandon]

Aus - if you get some time today and want to take a look at this one, it could be useful. Thanks!

Comment 8

[Aus Lacroix [:aus]]

Pretty sure this is a big part of the problem:

E/GeckoConsole( 1507): [JavaScript Error: "NS_NOINTERFACE: " {file: "jar:file:///system/b2g/omni.ja!/components/ActivityWrapper.js" line: 73}]

when hitting the home button. 

Looks like the context for the activity is a little messed up. I'll keep you guys posted.

Comment 9

[Aus Lacroix [:aus]]

Attachment: Pull Request - Hide value selector on 'activityclosing'

Alive, if this is the correct approach to fix this bug I will add tests to the pull request and flag for review.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8441296 [details] [review]
Pull Request - Hide value selector on 'activityclosing'

WFM

Comment 11

[Aus Lacroix [:aus]]

Comment on attachment 8441296 [details] [review]
Pull Request - Hide value selector on 'activityclosing'

Added some tests for this (and the other times we hide based on events).

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8441296 [details] [review]
Pull Request - Hide value selector on 'activityclosing'

r=me thanks.

Comment 13

[Aus Lacroix [:aus]]

Commit (master): https://github.com/mozilla-b2g/gaia/commit/5a53248d2404b6aa292c5d425f62c222e5cc1fd2

Commit (2.0): https://github.com/mozilla-b2g/gaia/commit/83844c7679b3b9f6e7f1116c1eeec2d1e7a64eec

Fixed!

Comment 14

[Elie]

Attachment: VIDEO0067_Compress.MP4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141127000203
Version         32.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.1:
Gaia-Rev        5372b675e018b6aac97d95ff5db8d4bd16addb9b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b
Build-ID        20141127001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2