1024588 - UA override list system causes sporadic connections to dynamicua.cdn.mozilla.net

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Nathan Froyd [:froydnj]]

With the patches in bug 995417 applied (which forbid network connections to non-local sites):

09:41:04     INFO -  *** UTM:SVC TimerManager:notify - notified timerID: user-agent-updates-timer
09:41:04     INFO -  Non-local network connections are disabled and a connection attempt to dynamicua.cdn.mozilla.net was made.  You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests).
09:41:05     INFO -  TEST-INFO | Main app process: killed by SIGSEGV
09:41:05  WARNING -  TEST-UNEXPECTED-FAIL | /tests/dom/imptests/html/dom/nodes/test_case.html | application terminated with exit code 11

(The particular test isn't at fault, so far as I can tell, it's just when the update timer happens to go off that problems ensue.)

These updates should be disabled for all tests, and any tests which specifically depend on the updates being available should use a test-only local server.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: turn off useragent updates for tests, to avoid hitting the network

Looking at the code, I think it does the right thing when the pref is off.
Testing this on try:

https://tbpl.mozilla.org/?tree=Try&rev=825ca25aa598

Getting tired of setting prefs in multiple places...

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Nathan Froyd (:froydnj) from comment #1)
> Looking at the code, I think it does the right thing when the pref is off.
> Testing this on try:
> 
> https://tbpl.mozilla.org/?tree=Try&rev=825ca25aa598

Looks like the patch works, hooray!

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8439453 [details] [diff] [review]
turn off useragent updates for tests, to avoid hitting the network

Review of attachment 8439453 [details] [diff] [review]:
-----------------------------------------------------------------

yes, so many prefs.  Should we do this for talos as well?

Comment 4

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/09d24ac458bb

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/09d24ac458bb

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e6bd7a69caef
https://hg.mozilla.org/releases/mozilla-beta/rev/f35d4325f9e7
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/591d1d56cdef
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/75ee2ac4083d

We should probably get a follow-up bug on file for getting this and bug 1025959 changed for talos too.