916205 - Create and enable dynamic UA override list in B2G

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

The dynamic UA override list is in JSON format. We need to convert the old override prefs to JSON and check it into Gaia. This way, the list ships with Gaia and the file on the server can track the file in the Gaia repo.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add and package UA override list (v1)

This patch includes a new UA override list converted from the current list in Gaia. The reason it's moved to Gecko is because we want to ship the file in the Gecko package.

The patch also includes the prefs to turn on the new UA override system, which will use the new list. I verified it to work on a B2G build on my Unagi device.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Remove UA override list from Gaia: https://github.com/mozilla-b2g/gaia/pull/12226

When the above Gecko patch lands, the old list in Gaia can be safely deleted.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 804822 [details] [diff] [review]
Add and package UA override list (v1)

Asking review on the Makefile bits

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 804822 [details] [diff] [review]
Add and package UA override list (v1)

Review of attachment 804822 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/app/Makefile.in
@@ +96,5 @@
> +	# strip out comment lines, which are not valid in JSON
> +	sed -e "/^ *\\/\\//d" -e "/^ *$$/d" $^ > $@
> +
> +libs:: $(UA_UPDATE_FILE)
> +	$(INSTALL) $(IFLAGS1) $^ $(FINAL_TARGET)

Use INSTALL_TARGETS (see config/rules.mk)

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add and package UA override list (v2)

I think this is right. Carrying over fabrice's r+ and re-asking review on Makefile bits

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Checked into https://hg.mozilla.org/integration/b2g-inbound/rev/82d40fae202d

Also noming for koi because we want dynamically updatable UA override list to work for 1.2

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/82d40fae202d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6390b4803456

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

The Gaia pull request still needs to be merged into master and 1.2 branch

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/18bd102d833e858e97d60db5c05607e172a10859

Will leave it to jhford to do the uplift.

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

[v1.2 51f3c79] Merge pull request #12226 from darchons/bug916205-create-and-enable-dynamic-ua