[Camera] Add Camera app to whitelistedUnifiedApps

RESOLVED FIXED in Firefox OS v2.0

Status

Firefox OS
Gaia::Camera
P1
blocker
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: justindarc, Assigned: justindarc)

Tracking

({perf})

unspecified
2.0 S4 (20june)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v2.0 fixed, b2g-v2.1 fixed)

Details

(Whiteboard: [c=automation p= s= u=])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The new startup performance events were added to Camera in Bug 1015385. However, an entry needs to be added for the Camera app to the `whitelistedUnifiedApps` array in `tests/performance/startup_events_test.js`.
(Assignee)

Comment 1

4 years ago
Created attachment 8439548 [details] [review]
pull-request (master)

Eli: Flagging you for an easy review since this is your territory :-)
Attachment #8439548 - Flags: review?(eperelman)

Updated

4 years ago
Attachment #8439548 - Flags: review?(eperelman) → review+
(Assignee)

Comment 2

4 years ago
Landed on master:

https://github.com/mozilla-b2g/gaia/commit/ea748a0b69f22fdce7317d45ce2a7d03f5d3999e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Assignee: nobody → jdarcangelo

Comment 3

4 years ago
Comment on attachment 8439548 [details] [review]
pull-request (master)

Requesting uplift to 2.0 as it is important for meeting our release performance acceptance criteria. The associated patch for this implementation has already landed with the Camera app, so Camera is outputting the data but we cannot capture it without this entry.

[Feature/regressing bug #]: bug 996038
[User impact if declined]: none
[Describe test coverage new/current, TBPL]: Feature only triggers events for testing, no user-facing features or tests
[Risks and why]: Low, as there are no user-perceived changes
[String/UUID change made/needed]: n/a
Attachment #8439548 - Flags: approval-gaia-v2.0?

Updated

4 years ago
Blocks: 1038759

Comment 4

4 years ago
Bhavana + Preeti,

Can we get approval on this? It's blocking our ability to do fxOS 2.0 Performance Signoff.
Severity: normal → blocker
Flags: needinfo?(praghunath)
Flags: needinfo?(bbajaj)
Keywords: perf
Priority: -- → P1
Whiteboard: [c=automation p= s= u=]

Updated

4 years ago
Attachment #8439548 - Flags: approval-gaia-v2.0? → approval-gaia-v2.0+
Flags: needinfo?(bbajaj)

Comment 5

4 years ago
Clearing ni? based on previous approval.
Flags: needinfo?(praghunath)
v2.0: https://github.com/mozilla-b2g/gaia/commit/597975839c04e0198eb98c2c77474f057b5531e7
status-b2g-v2.0: --- → fixed
status-b2g-v2.1: --- → fixed
Target Milestone: --- → 2.0 S4 (20june)
You need to log in before you can comment on or make changes to this bug.