1024828 - [permission] there's a blank line between permission dialog and soft button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[[e-mail]]

Attachment: blank.png

after bug 1020959 landing, the device with soft button enabled (nexus 4) will show a blank line between permission dialog and soft button

Comment 1

[[e-mail]]

@kavin I saw you remove the top: 2.4rem in bug 1020959. The height is reserved for utility tray.

Does overlap the utility tray is an intent behavior?

Comment 2

[Kevin Grandon :kgrandon]

Yes, the idea is that the dialog should be full screen. The problem is that I did not remove the 2.4rem from here: https://github.com/KevinGrandon/gaia/blob/eb74a7d4e2848a0de6bec0810ddf27a6af2d3b64/apps/system/style/permission_manager/permission_manager.css#L37

You want to write a patch? If not I will do so in the next day or two. Thanks for filing the bug!

Comment 3

[[e-mail]]

Attachment: pull request redirect to github

thanks I just want confirm that. here's the patch

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8439645 [details] [review]
pull request redirect to github

Thanks for the quick patch!

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8439645 [details] [review]
pull request redirect to github

Note test is red and I didn't check what's red.

Comment 6

[[e-mail]]

It's contact's marionette error which also occur in truncated bug.

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/fbdcf8876d212c40d90dd6eab97dc6a736f7a5ae

thanks!