1020959 - [vertical] search bar is visible when geolocation prompt is present

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Zac C (:zac)]

Attachment: 2014-06-05-14-42-08.png

STR:
1. Set geolocation setting to 'ask' for Search Results app
2. Connect to wifi network
3. Perform an everything.me search
4. Wait for geolocation prompt


Device: Flame
Gaia      d2cfef555dabab415085e548ed44c48a99be5c32
Gecko     https://hg.mozilla.org/mozilla-central/rev/51b428be6213
BuildID   20140604235615
Version   32.0a1
ro.build.version.incremental=eng.cltbld.20140605.031251
ro.build.date=Thu Jun  5 03:13:01 EDT 2014

Comment 1

[Zac C (:zac)]

Attachment: 2014-06-05-14-42-08.png

Comment 2

[Jason Smith [:jsmith]]

The red color here looks...strange.

UX - What color is the status bar supposed to be here?

Comment 3

[Zac C (:zac)]

The red bar is where the status bar was but when the prompt comes up it appears to be hidden, thus the red is just the colour of the wallpaper image in that place.

Comment 4

[Stephany Wilkes]

Zac seems to have covered this. Flagging Patryk to double check that this should have the color of the wallpaper image.

Comment 5

[Kevin Grandon :kgrandon]

We have a transparent statusbar on the homescreen, since homescreen dialogs do not generally cover the statusbar, we are instead shown a whatever the top of the wallpaper is. 

I believe we are doing some work to show the statusbar background as we scroll the homescreen, perhaps we can use the same mechanism to show the statusbar background for dialogs.

Comment 6

[Patryk Adamczyk [:patryk] UX]

Attachment: My Experience

#1.

I had a less user friend experience with this screen. The keyboard instantly popped up so I couldn't dismiss the location dialog. 

I know you can long press on the space bar to dismiss the keyboard but most users won't know that, I totally forgot about it for the first few seconds. And pressed "close" instead.

So the keyboard needs to be suppressed in states like this.

#2.
I should not be able to try in search results while this dialog is up. It looks like I am typing on the dialog.

#3. 
The status bar should be covered up. This behavior is inconsistent system wide, sometimes its covered, sometimes its not. Showing the wallpaper like this breaks the intent of the design which aimed to make sure the user focuses on the actionable content, in this case they are focusing on the big red strip (status bar), not on the dialog actions. Also, a very popular dialog invoked from the homescreen is the wallpaper selection which covers the status bar. So it would be good to have consistency between the two.

Comment 7

[Jason Smith [:jsmith]]

UX - Is this is a blocker for 2.0 from a UX perspective? I'm guessing it is, given that it's right in the front of the user on first usage, but want to double check.

Comment 8

[Stephany Wilkes]

Flagging Jacqueline to double check but my answer is yes, we'd likely block.

Comment 9

[Jacqueline Savory [:jsavory] UX]

Yes I would agree that this is a blocker, as Jason said its one of the first things people see when they tap on search. Flagging Francis to confirm as he is working on this feature.

Comment 10

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Hey Alive =/ Trying to avoid giving you too many reviews, but I think you're the best person to look at this.

This patch changes the permission dialog to cover the entire screen. This brings it inline with other overlays such as the activity selector, and looks better than having a strip at the top. 

It also fixes the z-index problem where the searchbar is over the permission dialog (the searchbar is part of the statusbar).

Let me know what you think.

Comment 11

[Kevin Grandon :kgrandon]

Suppose I will assign to myself, but someone can steal if my patch is terrible.

Comment 12

[Kevin Grandon :kgrandon]

Thanks for the review. https://github.com/mozilla-b2g/gaia/commit/67dc6375e89642600d83d528e1572e4cde7fab10

I don't think the ni? for francis is needed, we'll request approval for 2.0 on this.

Comment 14

[Jason Smith [:jsmith]]

This is really more of a bug rather than a feature. The dupe is what I'm more worried about in terms of severity, since it's currently possible to open up the prompt easily with the keyboard up, making it impossible to interact with the perm prompt.

Comment 15

[Kevin Grandon :kgrandon]

Comment on attachment 8438864 [details] [review]
Github pull request

This is required for the vertical homescreen. We've done our best effort at testing and believe the tree will remain green with uplift.

Comment 16

[Kevin Grandon :kgrandon]

Uplifted: https://github.com/mozilla-b2g/gaia/commit/a3a5322692578e0a577fb7fa08e32144b2b05ba3

Comment 18

[Johan Lorenzo [:jlorenzo]]

No more overlap on master.

Comment 19

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/4

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/ff1100ba2ab8
Build-ID        20141204000228
Version         32.0

Flame v2.1 version:
Gaia-Rev        5655269098c7e82254e56933f1af05b4abe2a2f3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86608c9389b5
Build-ID        20141204001201
Version         34.0