1024923 - Video Cold Launch Time 150ms Regression

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

Description

[Jon Hylands [:jhylands]]

On Jan 31, 2014, the Video app's cold load launch time regressed by 150ms due to this patch:

caf4dde01228fe880bf93e151f0c2057f58bea41 is the first bad commit
commit caf4dde01228fe880bf93e151f0c2057f58bea41
Author: Kevin Grandon <[e-mail]>
Date:   Thu Jan 30 11:31:12 2014 -0800

    Bug 962655 - Use build-time preference to enable rocketbar r=vingtetun, yurenju

(Please see bug 1002842 for the bisection leading to this)

Clearly, this can't be backed out at this time, but we need to figure out specifically what caused the issue, and see if it can be fixed.

Comment 1

[Jon Hylands [:jhylands]]

Kevin, can you look at this and comment?

Comment 2

[Kevin Grandon :kgrandon]

Wow! This is actually really old, and this patch has since been disabled. I don't really think we can do anything more here except for being proactive about performance the next time rocketbar lands. I'm assuming we recovered from this somewhere down the line (when we disabled rocketbar)?

Comment 3

[Jon Hylands [:jhylands]]

When did the patch get disabled?

Comment 4

[Kevin Grandon :kgrandon]

It was turned off on Feb 21: https://github.com/mozilla-b2g/gaia/commit/eba290a91ca1a529c48d3145cd4a97d78ed7913c

Comment 5

[bhavana bajaj [:bajaj]]

NI :jhylands to confirm this may be INVALID at this point given its disabled?

Comment 6

[Jon Hylands [:jhylands]]

I can concur, this is invalid, as it was backed out. The corresponding drop happened on Feb 24.