Closed Bug 1024943 Opened 9 years ago Closed 9 years ago

Check IsContentParent() before use AsContentParent()

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: kanru, Assigned: kanru)

References

Details

Attachments

(1 file)

patch
7.50 KB, patch
smaug
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
Before we fix bug 1020172, bypass the check for TabParents in a content process.
Attachment #8439804 - Flags: review?(bugs)
Comment on attachment 8439804 [details] [diff] [review]
patch

Can you please file a followup bug to use 
Preferences::AddBoolVarCache for "dom.testing.ignore_ipc_principal".
We really don't want to use Preferences::Get* in this kind of rather hot
code.
Make the followup to block bug 923625.
Attachment #8439804 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/8d99f061ec35
Assignee: nobody → kanru
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.