Closed Bug 1024947 Opened 5 years ago Closed 5 years ago

[vertical homescreen] Lock search app orientation

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

x86_64
Linux
defect
Not set

Tracking

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S4 (20june)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: zcampbell, Assigned: jlal)

References

Details

Attachments

(2 files)

Attached image 2014-06-13-10-44-24.png
STR:
1. Connect to wifi
2. Orient device to landscape
3. Perform an e.me search
4. Wait for results to appear
5. Rotate device back to portrait

Icons are clipped and too large.






Device: Flame
Gaia      90777363ed0a4e6d32612074a12fb2c73c353a25
Gecko     https://hg.mozilla.org/mozilla-central/rev/aab3362f97e9
BuildID   20140612160203
Version   33.0a1
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014
Yuck. We need this fixed.
blocking-b2g: --- → 2.0?
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking+]
Component: Gaia::Everything.me → Gaia::Search
Landscape actually works decently for the search app surprisingly. Perhaps we could just re-render and fix things if we wanted to keep landscape, otherwise we should disable it.
Assignee: nobody → jlal
See Also: → 1022022
Summary: [vertical homescreen] search results icons look poor after landscape > portrait → [vertical homescreen] Lock search app orientation
verbal r+ from kgrandon... this is a tiny one line change to force search app not to rotate. There is still a bug in the system app (in my build anyway) where if the search app could rotate other apps will rotate while closing the search app (this is no longer possible since we prevent rotation in the search app manifest now).
Attachment #8440126 - Flags: review+
Landed: https://github.com/mozilla-b2g/gaia/commit/ad5b6be14132b75b777e521a2c30f984ae4a324f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
https://moztrap.mozilla.org/manage/case/13757/

Awesome! Verified on master.
Status: RESOLVED → VERIFIED
blocking-b2g: 2.0? → 2.0+
Ran across bug 1027266

Verified STR: 
Gaia      23e06c3624309db22ad9cb736d89700768b42b36
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/164b61458ca5
BuildID   20140619000200
Version   32.0a2
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014
Flame
You need to log in before you can comment on or make changes to this bug.