[vertical homescreen] Lock search app orientation

VERIFIED FIXED in Firefox OS v2.0

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: zcampbell, Assigned: jlal)

Tracking

unspecified
2.0 S4 (20june)
x86_64
Linux
Bug Flags:
in-moztrap +

Firefox Tracking Flags

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 8439810 [details]
2014-06-13-10-44-24.png

STR:
1. Connect to wifi
2. Orient device to landscape
3. Perform an e.me search
4. Wait for results to appear
5. Rotate device back to portrait

Icons are clipped and too large.






Device: Flame
Gaia      90777363ed0a4e6d32612074a12fb2c73c353a25
Gecko     https://hg.mozilla.org/mozilla-central/rev/aab3362f97e9
BuildID   20140612160203
Version   33.0a1
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014
Yuck. We need this fixed.
Blocks: 989848
blocking-b2g: --- → 2.0?
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking+]
Component: Gaia::Everything.me → Gaia::Search
Landscape actually works decently for the search app surprisingly. Perhaps we could just re-render and fix things if we wanted to keep landscape, otherwise we should disable it.
(Assignee)

Updated

5 years ago
Assignee: nobody → jlal
See Also: → bug 1022022
(Assignee)

Updated

5 years ago
Summary: [vertical homescreen] search results icons look poor after landscape > portrait → [vertical homescreen] Lock search app orientation
(Assignee)

Comment 3

5 years ago
Created attachment 8440126 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20513

verbal r+ from kgrandon... this is a tiny one line change to force search app not to rotate. There is still a bug in the system app (in my build anyway) where if the search app could rotate other apps will rotate while closing the search app (this is no longer possible since we prevent rotation in the search app manifest now).
Attachment #8440126 - Flags: review+
Landed: https://github.com/mozilla-b2g/gaia/commit/ad5b6be14132b75b777e521a2c30f984ae4a324f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
https://moztrap.mozilla.org/manage/case/13757/

Awesome! Verified on master.
Status: RESOLVED → VERIFIED

Updated

5 years ago
blocking-b2g: 2.0? → 2.0+
v2.0: https://github.com/mozilla-b2g/gaia/commit/9edb30b17db6facc35730e6d812be3a693944434
status-b2g-v2.0: --- → fixed
status-b2g-v2.1: --- → fixed
Target Milestone: --- → 2.0 S4 (20june)
Ran across bug 1027266

Verified STR: 
Gaia      23e06c3624309db22ad9cb736d89700768b42b36
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/164b61458ca5
BuildID   20140619000200
Version   32.0a2
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014
Flame
status-b2g-v2.0: fixed → verified
status-b2g-v2.1: fixed → verified
You need to log in before you can comment on or make changes to this bug.