1024947 - [vertical homescreen] Lock search app orientation

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Zac C (:zac)]

Attachment: 2014-06-13-10-44-24.png

STR:
1. Connect to wifi
2. Orient device to landscape
3. Perform an e.me search
4. Wait for results to appear
5. Rotate device back to portrait

Icons are clipped and too large.






Device: Flame
Gaia      90777363ed0a4e6d32612074a12fb2c73c353a25
Gecko     https://hg.mozilla.org/mozilla-central/rev/aab3362f97e9
BuildID   20140612160203
Version   33.0a1
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014

Comment 1

[Jason Smith [:jsmith]]

Yuck. We need this fixed.

Comment 2

[Kevin Grandon :kgrandon]

Landscape actually works decently for the search app surprisingly. Perhaps we could just re-render and fix things if we wanted to keep landscape, otherwise we should disable it.

Comment 3

[James Lal [:lightsofapollo]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/20513

verbal r+ from kgrandon... this is a tiny one line change to force search app not to rotate. There is still a bug in the system app (in my build anyway) where if the search app could rotate other apps will rotate while closing the search app (this is no longer possible since we prevent rotation in the search app manifest now).

Comment 4

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/ad5b6be14132b75b777e521a2c30f984ae4a324f

Comment 5

[Johan Lorenzo [:jlorenzo]]

Some regression since FL. I added new test cases into Moztrap. 

https://moztrap.mozilla.org/manage/case/13756/
https://moztrap.mozilla.org/manage/case/13755/
https://moztrap.mozilla.org/manage/case/13754/

Comment 6

[Johan Lorenzo [:jlorenzo]]

https://moztrap.mozilla.org/manage/case/13757/

Awesome! Verified on master.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/9edb30b17db6facc35730e6d812be3a693944434

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Ran across bug 1027266

Verified STR: 
Gaia      23e06c3624309db22ad9cb736d89700768b42b36
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/164b61458ca5
BuildID   20140619000200
Version   32.0a2
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014
Flame