1022022 - [B2G][Vertical Homescreen] Orientation can be changed after a phone restart by opening and closing the Rocketbar

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Andrew Stole [:astole]]

Attachment: logcat

After a fresh restart, the device's homescreen orientation can be changed after opening and closing the e.me search bar. If an app is opened, the device's homescreen is locked in portrait orientation and works as expected.

Repro Steps:
1) Update a Flame to BuildID: 20140606040202
2) From a fresh restart or reset, tap on the e.me search bar
3) Close the search bar
4) Rotate the device

Actual:
The homescreen orientation changes from portrait to landscape

Expected:
The homescreen stays locked in portrait orientation

2.0 Environmental Variables:
Device: Flame 2.0 MOZ
BuildID: 20140606040202
Gaia: 857129928b6e56a809cee9d5445effb8fa9f1c2c
Gecko: c8288d0c7a15
Version: 32.0a1
Firmware Version: v10G-2

Repro frequency: 100%, 2/2
See attached: logcat, video

Comment 1

[Andrew Stole [:astole]]

This issue also occurs on 2.0 on Buri. 

2.0 Environmental Variables:
Device: Buri 2.0 MOZ
BuildID: 20140606040202
Gaia: 857129928b6e56a809cee9d5445effb8fa9f1c2c
Gecko: c8288d0c7a15
Version: 32.0a1
Firmware Version: v1.2-device.cfg

Comment 2

[Johan Lorenzo [:jlorenzo]]

I thought this was a duplicate of bug 1021468 at first. It was fixed yesterday but you've found an edge case. Good catch!

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Alive -  got time for a review?

I'm a bit confused here though, I thought having orientation: default in the manifest would accomplish this, locking it was the only thing that seemed to work.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8436560 [details] [review]
Github pull request

We should not do this :/ Please fix it in system app.
If you don't know how please assign to me.

Comment 5

[Kevin Grandon :kgrandon]

Ok, might be able to look at this tomorrow. Unassigning for now.

Comment 7

[Jason Smith [:jsmith]]

UX - The impact of this bug causes the homescreen to render in horizontally. Is this a blocker from your perspective?

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

The root cause is the search app which lives in searchWindow has no orientation specified.
So opened it causes the orientation be unlocked but nobody reset the orientation when its closed.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/20340

Proposed fix: reset orientation when search window is closing.

Comment 10

[Stephany Wilkes]

Yes, UX would block, for my $.02.

Comment 11

[Kevin Grandon :kgrandon]

Thank you for taking this alive. I think your fix is appropriate.

Comment 12

[Johan Lorenzo [:jlorenzo]]

Marked as 2.0? blocker as bad UX.

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/86174e824af843bd90a9d6ca9a5213dcaf82efe2

Comment 14

[Kevin Grandon :kgrandon]

Comment on attachment 8438244 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20340

This is required for the vertical homescreen. We've done our best effort at testing and believe the tree will remain green with uplift.

Comment 15

[Johan Lorenzo [:jlorenzo]]

I flashed my Flame to your commit with a production build and I'm still reproducing the issue. What about you Alive?

Here are more detailed STR:
1) Flash the Flame.
2) Go through FTU.
3) Tap rocketbar.
4) Don't share your position.
5) Tap close on the rocketbar.
6) Rotate the device to landscape mode.

Build Info
Gaia      86174e824af843bd90a9d6ca9a5213dcaf82efe2
Gecko     https://hg.mozilla.org/mozilla-central/rev/9e8e3e903484
BuildID   20140612040203
Version   33.0a1
ro.build.version.incremental=104
ro.build.date=Fri Jun  6 17:35:09 CST 2014

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/4e8b16a1484f6c75d9aab73c0c7e3313ba6adde2

Comment 17

[Johan Lorenzo [:jlorenzo]]

Bug 1024947 has also been filed. Let's use it to catch the regression.

Comment 18

[Johan Lorenzo [:jlorenzo]]

It's okay on master. Bug 1024947 has also been verified.