Closed Bug 1024966 Opened 5 years ago Closed 5 years ago

SelectionCarets::UpdateSelectionCarets should check whether the frame is null or not

Categories

(Core :: Selection, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: slee, Assigned: mtseng)

References

Details

Attachments

(1 file)

When the element is hide, nsIContent, [1], will be null. If we do not skip it, it generates too many assertion fail and cause test case fails, [2]. 

[1] http://dxr.mozilla.org/mozilla-central/source/layout/base/SelectionCarets.cpp#472
[2] https://tbpl.mozilla.org/php/getParsedLog.php?id=41663846&tree=Try&full=1
Assignee: nobody → mtseng
Attached patch bug1024966Splinter Review
Check mResultContent before using it!
Attachment #8452958 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/c9b503e42352
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.