Closed Bug 1023688 (CopyPasteLegacy) Opened 5 years ago Closed 4 years ago
Caret & Selection Carets, and text selection/copy/paste support on B2G v2 .2
This is the meta bug for the legacy carets and copy & paste implementation on B2G branch v2.2. To make a feature request or bug report against B2G master, please make it depend on meta bug 1124074 which is for B2G branch v2.5 and above. Please see the wiki page for more information. https://wiki.mozilla.org/Copy_n_Paste
A META bug to trace status of text selection/copy/paste support on B2G
Bug 987040 is the main function blocker at this moment
4 main test case blockers. Bug 1023087 - window manager copy/paste marionette test Bug 987040 - copy/paste browser API mochitest Bug 1019441 - selection caret marionette test Bug 1020261 - touch caret marionette test We need at least these 4 test cases landed to guarantee basic quality of this feature.
Hi Morris, In order to make the selection caret easier to use, I revised the caret images. Please help me update these images below: text_caret_tilt_left.png email@example.com firstname.lastname@example.org email@example.com text_caret_tilt_right.png firstname.lastname@example.org email@example.com firstname.lastname@example.org text_caret.png email@example.com firstname.lastname@example.org email@example.com One other thing is that the hightlighting color looks different from the spec, please help me change it to #33b5e5, 40%. Thanks! Let me know when you finish these adjustment so I can have a UI review :)
Hi George, Text selection Visual spec revised: Please help adjust the utility menu's shadow. Shadow: 2px 2px 5px 3px #3d3d3d Let me know when you're done so I can see if the shadow looks good enough. Thank you!:)
What are the plans for the platform side of things here? We've been working on text selection support on b2g for a while, so I'm aware of that piece, but I'm not sure what our plans are with regards to supporting clipboard for non-text-only content in the content process, etc.
We will work on non-editable content copy and paste after these two bugs land Bug 987718 Bug 987040 Rich text(non-text-only) copy-paste should be a thing after.
Please check Bug 921965 to see the latest text selection Visual spec. thanks!!
Update text caret image assets(png)
Attachment #8439762 - Attachment is obsolete: true
Depends on: 1066192
Attaching OS-wide (core apps) text selection rules of thumb and UX guidelines.
Update UX spec for 2.2.
(In reply to Omega Feng [:Omega] [:馮於懋] (please ni?) from comment #10) > Created attachment 8521957 [details] > FxOS 2.2 UX Spec_Text Selection_v1.3.pdf > > Update UX spec for 2.2. ni Morris, TY for checking the 2.2 UX spec
Summarize differences between our implementation right now and ux spec. Based on spec: https://bugzilla.mozilla.org/attachment.cgi?id=8521957 Page 6, Long press on empty area would select last word. Page 7, Copy doesn’t hide carets and bubble. Page 9, Long press on empty field would do nothing. Page 10, Paste on password field shows unmask for seconds then mask. Page 12, Right now we’re at “no ok” case. Page 15, Keyboard always overlap carets. Page 16, We’ll show “select all” button event if we select all content. Page 26, Same as page 7, copy doesn’t hide carets and bubble.
> Page 7, Copy doesn’t hide carets and bubble. What I saw is that after copying, carets does not hide, the bubble hides, and the selection does not collapse.
(In reply to Ting-Yu Lin [:TYLin] (UTC+8) from comment #13) > > Page 7, Copy doesn’t hide carets and bubble. > What I saw is that after copying, carets does not hide, the bubble hides, > and the selection does not collapse. Ah, right. What I mean is carets doesn't hide and selection range remain un-change.
(In reply to Morris Tseng [:mtseng] from comment #12) > Summarize differences between our implementation right now and ux spec. > Based on spec: https://bugzilla.mozilla.org/attachment.cgi?id=8521957 > > Page 6, Long press on empty area would select last word. > Page 7, Copy doesn’t hide carets and bubble. > Page 9, Long press on empty field would do nothing. Current the long tap will show the caret on input filed. With my WIP of bug 1068461, it could trigger the touch caert and text dialog. > Page 10, Paste on password field shows unmask for seconds then mask. > Page 12, Right now we’re at “no ok” case. > Page 15, Keyboard always overlap carets. > Page 16, We’ll show “select all” button event if we select all content. > Page 26, Same as page 7, copy doesn’t hide carets and bubble.
QA Whiteboard: [2.2-feature-qa+][textselection] → [textselection]
QA Whiteboard: [textselection] → [textselection][2.2-feature-qa+]
Duplicate of this bug: 747798
No longer depends on: 1120358
UX spec update Password Input: Allow only "Select All" and "Paste" in password input
Attachment #8521957 - Attachment is obsolete: true
QA Whiteboard: [textselection][2.2-feature-qa+] → [COM=Text Selection][2.2-feature-qa+]
No longer depends on: 1130982
Test cases are here. https://moztrap.mozilla.org/manage/cases/?filter-suite=836
Flags: in-moztrap?(gchang) → in-moztrap+
Is there developer documentation on the mechanism by which the "select all" mechanism operates? In bug 1152172 it appears an unexpected common root is chosen for "select all" which is not what I would expect from the documentation at https://developer.mozilla.org/en-US/docs/Web/CSS/user-select. (And I couldn't find any better sources in a cursory searching of MDN, and there appear to be no normative implementation references here other than the attached UX specs that don't address this situation.)
As a follow-up, I've started a thread on dev.gaia about whether the current "select all" implementation should operate as it does since I was surprised that it really tries to select everything: https://groups.google.com/forum/#!topic/mozilla.dev.gaia/3tBQxCN5INQ
Alias: CopyPaste → CopyPasteLegacy
Assignee: howareyou322 → nobody
Summary: [META] Text selection/copy/paste support on B2G → [META] TouchCaret & SelectionCarets, and text selection/copy/paste support on B2G v2.2
The touch/selection carets in gecko, related event handling in browser-element, and text_selection_dialog.js in Gaia had been removed. This old meta bug is now officially retired, and the new meta bug is Bug 1124074. Thank you all for helping.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
11 months ago
You need to log in before you can comment on or make changes to this bug.