1025178 - [everything.me] Search results that have globe icons don't open

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Valentin Tsatskin [:vt]]

Device    Flame
Gaia      1b5557e5b9e2e194a466efd9bf91985efe311591
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/f1aebc2f1c58
BuildID   20140613061552
Version   32.0a2
ro.build.version.incremental=eng.cltbld.20140606.192117
ro.build.date=Fri Jun  6 19:21:29 EDT 2014

# Steps to reproduce

1) Enter a search term (e.g. "testing")
2) Click any result icon in the top row

# Expected Results

Pressing the icon opens the result

# Actual Results

Nothing happens.

# Frequency

Every time for all search terms

Comment 1

[Kevin Grandon :kgrandon]

Currently unable to reproduce. Adding qawanted to see if there is a STR here, and if so, logcat or video.

Comment 2

[Jason Smith [:jsmith]]

Moving to just qawanted to verify on the latest 2.0 build.

Comment 3

[Jason Smith [:jsmith]]

If reproducible this would be a FL blocker, but I think this will be a wfm.

Comment 4

[Cody Roesch [:croesch]]

Valentin,
      I have been able to reproduce this issue but have a question for you. I can repro this bug if websites use the Universal icons(globe). However if the website uses unique icons such as the Youtube, wikipedia icons, the bug does not happen.

Is there anyway that all the icons you were tapping on were the Universal (Globe) icons?

Example:
I typed in Testing into E.me and all websites that appeared had unique icons for their websites and the bug does NOT repro.

I typed in Testingp into E.me and see several universal (Globe) icons that do cause this issue you describe.

Here is a video for reference. Please let me know if i'm on the correct path here as I cannot get this bug without the globe icons appearing.
http://youtu.be/A8V8lcoKmHA

Comment 5

[Valentin Tsatskin [:vt]]

Pressing Globe icons cause the issue I described. Looks like I may have been mistaken initially when filling this bug. The top row must have had only globe icons leading me to to think the entire top row doesn't work.

Comment 6

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Dale - Root cause was that we were not passing in a proper ID (the id from E.me can come back null). When this happens we are unable to find the proper object via bubbling in gaia-grid. I obviously want to add a test, but I would like to wait until bug 1025586 lands so we have a solid starting point.

Comment 7

[Amir Nissim (:amirn)]

maybe we should ignore the id E.me sends and use the url as an identifier instead for consistency

Comment 8

[Ran Ben Aharon [:ranbena] EverythingMe]

Might it clash with a homescreen bookmark of the same url?

Comment 9

[Amir Nissim (:amirn)]

(In reply to Ran Ben Aharon (Everything.me) from comment #8)
> Might it clash with a homescreen bookmark of the same url?

That might actually be useful for deduping.

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8441144 [details] [review]
Github pull request

(In reply to Ran Ben Aharon (Everything.me) from comment #8)
> Might it clash with a homescreen bookmark of the same url?

Good point. Right now this is only for the search app and everything gets deduped anyway - so it's not on the screen. 

If you guys have some time to review this simple that would be great :)

Comment 11

[Kevin Grandon :kgrandon]

Thanks! Landed: https://github.com/mozilla-b2g/gaia/commit/0e1a7b33a47271a672f6449c80b62b9d7f1082f8

I'm also going to work on some integration tests for this as well.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/5352d862257d8ac8b52cf168f5c38713d7ef7ddb

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I hit a condition and would be resolved in the next build: https://bugzilla.mozilla.org/show_bug.cgi?id=1026716#c3

Verified fixed : 
Gaia      82e957160ca017087bd374cd051339e55b641e68
Gecko     https://hg.mozilla.org/mozilla-central/rev/f78e532e8a10
BuildID   20140619040201
Version   33.0a1
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014
Flame

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified on 2.0:

Gaia      23e06c3624309db22ad9cb736d89700768b42b36
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/164b61458ca5
BuildID   20140619000200
Version   32.0a2
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014
flame