1025299 - (vertical-homescreen) Marketplace icon is still using the old version

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P2)

Description

[Peter La]

The marketplace icon is not using the latest 2.0 app icon for Marketplace.  That icon can be found in this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1014591

The thing about the marketplace icon, is that I don't think it's represented as a png file in the filesystem, but as far as I can remember, is defined inside a text file in gaia, as hex codes.  This is probably why it's not showing up, and why the above referenced bug didn't update it properly.

Comment 1

[Peter La]

Attachment: This shows the homescreen using the old marketplace icon

Comment 2

[Peter La]

Attachment: This is the new (correct) marketplace icon for 2.0

Comment 3

[Kevin Grandon :kgrandon]

Hey Peter - I believe we will need to support 1.4 and below if we update this as the marketplace is a hosted app. We should get some additional icon resolutions.

Can you also please provide the following resolutions for marketplace: 

- 60
- 90
- 120

They also have a 128, but I think we should be good with those three, and the others that we use in 2.0. Thanks!

Comment 4

[Kevin Grandon :kgrandon]

It's a hosted app so I think we have some more time, but we should definitely try to test this out asap. Moving to block vhomescreen.next.

Comment 5

[Wil Clouser [:clouserw]]

(In reply to Kevin Grandon :kgrandon from comment #4)
> It's a hosted app so I think we have some more time, but we should
> definitely try to test this out asap. Moving to block vhomescreen.next.

The marketplace is a packaged app.  If you'd like to update the icon, please attach the assets to this bug (looks like there is a current needinfo for them, so we should be good)

Comment 6

[Hung Nguyen]

Attachment: Marketplace_Icons.zip

Attaching additional sizes (60,90,120). 

Let me know if there anything else required. 

Cheers!

Comment 7

[Cristian Rodriguez (:crdlc)]

Hi Hung, the marketplace defines those icons:

"icons": {
        "60": "/60.png",
        "90": "/90.png",
        "120": "/120.png",
        "128": "/128.png",
        "256": "/256.png"
    },

Could you provide us 128 and 256, thanks a lot

(In reply to Hung Nguyen from comment #6)
> Created attachment 8441379 [details]
> Marketplace_Icons.zip
> 
> Attaching additional sizes (60,90,120). 
> 
> Let me know if there anything else required. 
> 
> Cheers!

Comment 8

[Hung Nguyen]

Attachment: Marketplace_Icons_V02.zip

Attaching new sizes. Let me know if you need anything else. 

Thanks Cristian.

Comment 9

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Hi Michael, could you explain how I can change the etag and packageEtag? Many thanks

Comment 10

[Wil Clouser [:clouserw]]

http://marketplace.readthedocs.org/en/latest/topics/package.html#preload-a-new-package-in-firefox-os has instructions for the etags

Comment 11

[Cristian Rodriguez (:crdlc)]

No idea how I have to do this so releasing this bug. I don't understand those steps when I am modifying the application.zip locally and I am obtaining the etag value from remote zip. Please Kevin if you have any idea how to do that, please take it

Comment 12

[Wil Clouser [:clouserw]]

I'll handle it

Comment 13

[Wil Clouser [:clouserw]]

This was done a couple weeks ago in https://github.com/mozilla/fireplace/commit/f5045334433f8b7a072d98fd05927ba8cb5fa24f