Closed Bug 1025299 Opened 5 years ago Closed 5 years ago

(vertical-homescreen) Marketplace icon is still using the old version

Categories

(Marketplace Graveyard :: General, defect, P2)

Avenir
x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
2014-07-01

People

(Reporter: pla, Assigned: cvan)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, [ft:systemsfe][systemsfe])

Attachments

(3 files, 2 obsolete files)

The marketplace icon is not using the latest 2.0 app icon for Marketplace.  That icon can be found in this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1014591

The thing about the marketplace icon, is that I don't think it's represented as a png file in the filesystem, but as far as I can remember, is defined inside a text file in gaia, as hex codes.  This is probably why it's not showing up, and why the above referenced bug didn't update it properly.
Hey Peter - I believe we will need to support 1.4 and below if we update this as the marketplace is a hosted app. We should get some additional icon resolutions.

Can you also please provide the following resolutions for marketplace: 

- 60
- 90
- 120

They also have a 128, but I think we should be good with those three, and the others that we use in 2.0. Thanks!
Flags: needinfo?(pla)
It's a hosted app so I think we have some more time, but we should definitely try to test this out asap. Moving to block vhomescreen.next.
Blocks: vertical-home-next
No longer blocks: vertical-homescreen
Component: Gaia::Homescreen → General
Product: Firefox OS → Marketplace
Version: unspecified → Avenir
(In reply to Kevin Grandon :kgrandon from comment #4)
> It's a hosted app so I think we have some more time, but we should
> definitely try to test this out asap. Moving to block vhomescreen.next.

The marketplace is a packaged app.  If you'd like to update the icon, please attach the assets to this bug (looks like there is a current needinfo for them, so we should be good)
Whiteboard: ux-tracking, visual design, visual-tracking, [ft:systemsfe][systemsfe][2.0-FL-bug-bash] → ux-tracking, visual design, visual-tracking, [ft:systemsfe][systemsfe]
Attached file Marketplace_Icons.zip (obsolete) —
Attaching additional sizes (60,90,120). 

Let me know if there anything else required. 

Cheers!
Flags: needinfo?(pla)
Hi Hung, the marketplace defines those icons:

"icons": {
        "60": "/60.png",
        "90": "/90.png",
        "120": "/120.png",
        "128": "/128.png",
        "256": "/256.png"
    },

Could you provide us 128 and 256, thanks a lot

(In reply to Hung Nguyen from comment #6)
> Created attachment 8441379 [details]
> Marketplace_Icons.zip
> 
> Attaching additional sizes (60,90,120). 
> 
> Let me know if there anything else required. 
> 
> Cheers!
Flags: needinfo?(hnguyen)
Attaching new sizes. Let me know if you need anything else. 

Thanks Cristian.
Attachment #8441379 - Attachment is obsolete: true
Flags: needinfo?(hnguyen)
Attached file Github pull request (obsolete) —
Hi Michael, could you explain how I can change the etag and packageEtag? Many thanks
Flags: needinfo?(mhenretty)
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attachment #8444345 - Attachment is obsolete: true
Flags: needinfo?(mhenretty)
Assignee: crdlc → nobody
No idea how I have to do this so releasing this bug. I don't understand those steps when I am modifying the application.zip locally and I am obtaining the etag value from remote zip. Please Kevin if you have any idea how to do that, please take it
Flags: needinfo?(kgrandon)
I'll handle it
Assignee: nobody → clouserw
Flags: needinfo?(kgrandon)
Priority: -- → P2
This was done a couple weeks ago in https://github.com/mozilla/fireplace/commit/f5045334433f8b7a072d98fd05927ba8cb5fa24f
Assignee: clouserw → cvan
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-07-01
See Also: → 1054534
You need to log in before you can comment on or make changes to this bug.