Closed Bug 1025359 Opened 6 years ago Closed 6 years ago

Correct -moz-tamil according to Predefined Counter Styles

Categories

(Core :: CSS Parsing and Computation, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: xidorn, Assigned: xidorn)

Details

Attachments

(1 file)

Currently we have an incorrect -moz-tamil. Given that the W3C International WG has provided an implementation in Predefined Counter Styles [1], it should be good to follow this document.

The only difference between the document and our current implementation is the representation of zero and the range.

[1]: http://www.w3.org/TR/predefined-counter-styles/
Attached patch patchSplinter Review
Attachment #8440197 - Flags: review?(jfkthame)
Comment on attachment 8440197 [details] [diff] [review]
patch

Review of attachment 8440197 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, let's do it. Much cleaner.

Just out of interest, I looked back at the history of this. The implementation in TamilToText() appears to date back all the way to April 2000:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/layout/generic&command=DIFF_FRAMESET&file=nsBulletFrame.cpp&rev2=1.43&rev1=1.42

But the Tamil digit zero did not exist at that time; it was added to Unicode in version 4.1, which was released in March 2005. So that's why we didn't originally have Tamil implemented the way it is now specified.

Anyway, thanks for fixing it!
Attachment #8440197 - Flags: review?(jfkthame) → review+
(In reply to Jonathan Kew (:jfkthame) from comment #2)
> Just out of interest, I looked back at the history of this. The
> implementation in TamilToText() appears to date back all the way to April
> 2000:
> 
> http://bonsai.mozilla.org/cvsview2.
> cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/
> layout/generic&command=DIFF_FRAMESET&file=nsBulletFrame.cpp&rev2=1.43&rev1=1.
> 42
> 
> But the Tamil digit zero did not exist at that time; it was added to Unicode
> in version 4.1, which was released in March 2005. So that's why we didn't
> originally have Tamil implemented the way it is now specified.
> 
> Anyway, thanks for fixing it!

Oh, that make sense!

I don't think it could break anything so let's mark it checkin-needed.

BTW, this patch should be applied after the patch for bug 985825.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6b7c8900242a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Demo:

@counter-style ancient-tamil {
system: additive;
range: 1 9999;
additive-symbols: 9000 '\BEF\BF2', 8000 '\BEE\BF2', 7000 '\BED\BF2', 6000 '\BEC\BF2', 5000 '\BEB\BF2', 4000 '\BEA\BF2', 3000 '\BE9\BF2', 2000 '\BE8\BF2', 1000 '\BF2', 900 '\BEF\BF1', 800 '\BEE\BF1', 700 '\BED\BF1', 600 '\BEC\BF1', 500 '\BEB\BF1', 400 '\BEA\BF1', 300 '\BE9\BF1', 200 '\BE8\BF1', 100 '\BF1', 90 '\BEF\BF0', 80 '\BEE\BF0', 70 '\BED\BF0', 60 '\BEC\BF0', 50 '\BEB\BF0', 40 '\BEA\BF0', 30 '\BE9\BF0', 20 '\BE8\BF0', 10 '\BF0', 9 '\BEF', 8 '\BEE', 7 '\BED', 6 '\BEC', 5 '\BEB', 4 '\BEA', 3 '\BE9', 2 '\BE8', 1 '\BE7';
/* additive-symbols: 9000 '௯௲', 8000 '௮௲', 7000 '௭௲', 6000 '௬௲', 5000 '௫௲', 4000 '௪௲', 3000 '௩௲', 2000 '௨௲', 1000 '௲', 900 '௯௱', 800 '௮௱', 700 '௭௱', 600 '௬௱', 500 '௫௱', 400 '௪௱', 300 '௩௱', 200 '௨௱', 100 '௱', 90 '௯௰', 80 '௮௰', 70 '௭௰', 60 '௬௰', 50 '௫௰', 40 '௪௰', 30 '௩௰', 20 '௨௰', 10 '௰', 9 '௯', 8 '௮', 7 '௭', 6 '௬', 5 '௫', 4 '௪', 3 '௩', 2 '௨', 1 '௧'; */
}
@counter-style tamil {
system: numeric;
symbols: '\BE6' '\BE7' '\BE8' '\BE9' '\BEA' '\BEB' '\BEC' '\BED' '\BEE' '\BEF';
/* symbols: '௦' '௧' '௨' '௩' '௪' '௫' '௬' '௭' '௮' '௯'; */
}
You need to log in before you can comment on or make changes to this bug.