Closed Bug 1025768 Opened 10 years ago Closed 10 years ago

Async readers broke eager SourceBuffer switching

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: kinetik, Assigned: kinetik)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Restore eager SourceBuffer switching.
5.58 KB, patch
cajbir
: review+
Details | Diff | Splinter Review 
One of the patches in bug 979104 reverted the change made in bug 1002320 to switch SourceBuffers eagerly.
Is there a test case (even a stand alone page) I can use to verify that it's not regressed?
Lack of real tests is why it broke, I'm hoping to focus on getting those into the tree Real Soon Now.

For ad-hoc testing, if you change resolutions manually in YouTube's DASH player it should switch relatively quickly; if the switch is significantly delayed then that's this bug.

I'll fix this by implementing the (minimal necessary, for now) coded frame processing algorithm from the spec rather than the ad-hoc switching I had in place earlier.

        Attachment #8458429 -
        Flags: review?(cajbir.bugzilla)

    
  

        Attachment #8458429 -
        Flags: review?(cajbir.bugzilla) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/9926ef67edb3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: