Closed Bug 1000686 Opened 10 years ago Closed 10 years ago

Unpref Media Source Extensions (for WebM) in non-release builds.

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: kinetik, Assigned: cajbir)

References

Details

(Keywords: dev-doc-needed)

Attachments

(1 file, 4 obsolete files)

Spinning this off from a patch in bug 881512 to track it separately since the current plan is to land this change later than the other patches.
Blocks: 881512, MSE
Carrying over cajbir's review from bug 881512.
Attachment #8411549 - Flags: review+
To land this, also need a patch to update dom/tests/mochitest/general/test_interfaces.html for MediaSource, SourceBuffer, SourceBufferList, VideoPlaybackQuality.

Also should (have already) email an intent to implement, and possibly an intent to ship: https://wiki.mozilla.org/WebAPI/ExposureGuidelines#Intent_to_Implement and https://wiki.mozilla.org/WebAPI/ExposureGuidelines#Intent_to_Ship.  It's not clear if the intent to ship is needed until the RELEASE_BUILD ifdef is removed, but I strongly suspect not.
Also need to change the test in content/media/mediasource/test/test_MediaSource.html.
See Also: → 986381
Attached patch bug1000686_v1.patch (obsolete) — Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=a936c650e7b1
Attachment #8411549 - Attachment is obsolete: true
Attachment #8413113 - Flags: review?(cajbir.bugzilla)
Attachment #8413113 - Flags: review?(bugs)
Attachment #8413113 - Flags: review?(cajbir.bugzilla) → review+
Attachment #8413113 - Flags: review?(bugs) → review+
I landed the MIME whitelist part early, because I don't want to have to deal with a bunch of MSE bugs in the MP4 handling code that we're not ready to deal with yet.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc6a9d65b84f
Keywords: leave-open
Attached patch bug1000686_p2_v2.patch (obsolete) — Splinter Review
This is the rest of the patch.  Carrying forward r+ from cajbir and smaug.
Attachment #8413113 - Attachment is obsolete: true
Attachment #8413454 - Flags: review+
(In reply to Matthew Gregan [:kinetik] from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/bc6a9d65b84f

Merged to m-c:

(In reply to Matthew Gregan [:kinetik] from comment #48)
> (In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #47)
> > https://hg.mozilla.org/mozilla-central/rev/bc6a9d65b84f
> 
> Oops, that's actually for bug 1000686, but I forgot to fix the commit
> message when splitting the bugs.
Keywords: leave-open
Attached patch bug1000686_v2.patch (obsolete) — Splinter Review
Identical to previous patch, except the commit message has been fixed to point to this bug.
Attachment #8413454 - Attachment is obsolete: true
Attachment #8413476 - Flags: review+
Depends on: 1002297
Depends on: 77992
Depends on: 1022479
Depends on: 1024858
Depends on: 1025768
Depends on: 1025770
Depends on: 1028642
Depends on: 1028742
Depends on: 1031532
Blocks: 1031121
Depends on: 1056440
No longer depends on: 1022479
Depends on: 1041396
Depends on: 1044498
Depends on: 1061007
Depends on: 1062017
Depends on: 1062055
Seeing the behaviour described in Bug 1024858, though that is marked Resolved. Can’t
Blocks: 1067558
(In reply to John Drinkwater (:beta) from comment #9)
> Seeing the behaviour described in Bug 1024858, though that is marked
> Resolved. Can’t

Please retest with a current nightly, it should work better, although there are still bugs outstanding (see list of bugs this bug depends on).
Assignee: kinetik → nobody
Status: ASSIGNED → NEW
Attachment #8413476 - Attachment is obsolete: true
Attachment #8413476 - Flags: review+
Attachment #8411549 - Flags: review+
Attachment #8413113 - Flags: review+
Attachment #8413454 - Flags: review+
Attached patch 1000686.patchSplinter Review
Patch enables MSE for non-release builds.
Assignee: nobody → cajbir.bugzilla
Status: NEW → ASSIGNED
Attachment #8510663 - Flags: review?(ajones)
Attachment #8510663 - Flags: review?(ajones) → review+
Remaining open dependant bugs moved to bug 1088553.
No longer depends on: 1062055, 1068483
https://hg.mozilla.org/mozilla-central/rev/918f4681e3f0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Was this wise? YouTube still has playback issues with WebM. None of them are tracked in the YouTube-MSE bug.
I don't know about you guys but i'm still facing several issues with the YouTube HTML5 player too (Video totally freezing, buffer stops when i'm fast-forwarding or scrolling, comment section not loading and so on.......) these issues tend to be less severe when Adblock plus is disabled BTW
(In reply to Leman Bennett [Omega] from comment #16)
> Was this wise? YouTube still has playback issues with WebM. None of them are
> tracked in the YouTube-MSE bug.

If they are not tracked, we don't know about them. Please raise bugs or describe the issues, with links to videos, so we can track them down.
Depends on: 1089937
Depends on: 1092932
Depends on: 1135062
You need to log in before you can comment on or make changes to this bug.