1000686 - Unpref Media Source Extensions (for WebM) in non-release builds.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

Spinning this off from a patch in bug 881512 to track it separately since the current plan is to land this change later than the other patches.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Unpref-Media-Source-Extensions-for-We.patch

Carrying over cajbir's review from bug 881512.

Comment 2

[Matthew Gregan [:kinetik]]

To land this, also need a patch to update dom/tests/mochitest/general/test_interfaces.html for MediaSource, SourceBuffer, SourceBufferList, VideoPlaybackQuality.

Also should (have already) email an intent to implement, and possibly an intent to ship: https://wiki.mozilla.org/WebAPI/ExposureGuidelines#Intent_to_Implement and https://wiki.mozilla.org/WebAPI/ExposureGuidelines#Intent_to_Ship.  It's not clear if the intent to ship is needed until the RELEASE_BUILD ifdef is removed, but I strongly suspect not.

Comment 3

[Matthew Gregan [:kinetik]]

Also need to change the test in content/media/mediasource/test/test_MediaSource.html.

Comment 4

[Matthew Gregan [:kinetik]]

Attachment: bug1000686_v1.patch

https://tbpl.mozilla.org/?tree=Try&rev=a936c650e7b1

Comment 5

[Matthew Gregan [:kinetik]]

I landed the MIME whitelist part early, because I don't want to have to deal with a bunch of MSE bugs in the MP4 handling code that we're not ready to deal with yet.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc6a9d65b84f

Comment 6

[Matthew Gregan [:kinetik]]

Attachment: bug1000686_p2_v2.patch

This is the rest of the patch.  Carrying forward r+ from cajbir and smaug.

Comment 7

[Matthew Gregan [:kinetik]]

(In reply to Matthew Gregan [:kinetik] from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/bc6a9d65b84f

Merged to m-c:

(In reply to Matthew Gregan [:kinetik] from comment #48)
> (In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #47)
> > https://hg.mozilla.org/mozilla-central/rev/bc6a9d65b84f
> 
> Oops, that's actually for bug 1000686, but I forgot to fix the commit
> message when splitting the bugs.

Comment 8

[Matthew Gregan [:kinetik]]

Attachment: bug1000686_v2.patch

Identical to previous patch, except the commit message has been fixed to point to this bug.

Comment 9

[John Drinkwater (:beta)]

Seeing the behaviour described in Bug 1024858, though that is marked Resolved. Can’t

Comment 10

[Matthew Gregan [:kinetik]]

(In reply to John Drinkwater (:beta) from comment #9)
> Seeing the behaviour described in Bug 1024858, though that is marked
> Resolved. Can’t

Please retest with a current nightly, it should work better, although there are still bugs outstanding (see list of bugs this bug depends on).

Comment 11

[Achwaq Khalid]

See: https://bugzilla.mozilla.org/show_bug.cgi?id=1060406

Comment 12

[cajbir (:cajbir)]

Attachment: 1000686.patch

Patch enables MSE for non-release builds.

Comment 13

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/918f4681e3f0

Comment 14

[cajbir (:cajbir)]

Remaining open dependant bugs moved to bug 1088553.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/918f4681e3f0

Comment 16

[Leman Bennett [Omega]]

Was this wise? YouTube still has playback issues with WebM. None of them are tracked in the YouTube-MSE bug.

Comment 17

[Achwaq Khalid]

I don't know about you guys but i'm still facing several issues with the YouTube HTML5 player too (Video totally freezing, buffer stops when i'm fast-forwarding or scrolling, comment section not loading and so on.......) these issues tend to be less severe when Adblock plus is disabled BTW

Comment 18

[cajbir (:cajbir)]

(In reply to Leman Bennett [Omega] from comment #16)
> Was this wise? YouTube still has playback issues with WebM. None of them are
> tracked in the YouTube-MSE bug.

If they are not tracked, we don't know about them. Please raise bugs or describe the issues, with links to videos, so we can track them down.