Unpref Media Source Extensions (for WebM) in non-release builds.

RESOLVED FIXED in mozilla36

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: kinetik, Assigned: cajbir)

Tracking

({dev-doc-needed})

Trunk
mozilla36
dev-doc-needed
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Reporter)

Description

3 years ago
Spinning this off from a patch in bug 881512 to track it separately since the current plan is to land this change later than the other patches.
(Reporter)

Updated

3 years ago
Blocks: 881512, 778617
(Reporter)

Comment 1

3 years ago
Created attachment 8411549 [details] [diff] [review]
Unpref-Media-Source-Extensions-for-We.patch

Carrying over cajbir's review from bug 881512.
Attachment #8411549 - Flags: review+
(Reporter)

Comment 2

3 years ago
To land this, also need a patch to update dom/tests/mochitest/general/test_interfaces.html for MediaSource, SourceBuffer, SourceBufferList, VideoPlaybackQuality.

Also should (have already) email an intent to implement, and possibly an intent to ship: https://wiki.mozilla.org/WebAPI/ExposureGuidelines#Intent_to_Implement and https://wiki.mozilla.org/WebAPI/ExposureGuidelines#Intent_to_Ship.  It's not clear if the intent to ship is needed until the RELEASE_BUILD ifdef is removed, but I strongly suspect not.
(Reporter)

Comment 3

3 years ago
Also need to change the test in content/media/mediasource/test/test_MediaSource.html.
(Reporter)

Updated

3 years ago
See Also: → bug 986381
(Reporter)

Comment 4

3 years ago
Created attachment 8413113 [details] [diff] [review]
bug1000686_v1.patch

https://tbpl.mozilla.org/?tree=Try&rev=a936c650e7b1
Attachment #8411549 - Attachment is obsolete: true
Attachment #8413113 - Flags: review?(cajbir.bugzilla)
Attachment #8413113 - Flags: review?(bugs)
(Assignee)

Updated

3 years ago
Attachment #8413113 - Flags: review?(cajbir.bugzilla) → review+

Updated

3 years ago
Attachment #8413113 - Flags: review?(bugs) → review+
(Reporter)

Comment 5

3 years ago
I landed the MIME whitelist part early, because I don't want to have to deal with a bunch of MSE bugs in the MP4 handling code that we're not ready to deal with yet.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc6a9d65b84f
Keywords: leave-open
(Reporter)

Comment 6

3 years ago
Created attachment 8413454 [details] [diff] [review]
bug1000686_p2_v2.patch

This is the rest of the patch.  Carrying forward r+ from cajbir and smaug.
Attachment #8413113 - Attachment is obsolete: true
Attachment #8413454 - Flags: review+
(Reporter)

Comment 7

3 years ago
(In reply to Matthew Gregan [:kinetik] from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/bc6a9d65b84f

Merged to m-c:

(In reply to Matthew Gregan [:kinetik] from comment #48)
> (In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #47)
> > https://hg.mozilla.org/mozilla-central/rev/bc6a9d65b84f
> 
> Oops, that's actually for bug 1000686, but I forgot to fix the commit
> message when splitting the bugs.
Keywords: leave-open
(Reporter)

Comment 8

3 years ago
Created attachment 8413476 [details] [diff] [review]
bug1000686_v2.patch

Identical to previous patch, except the commit message has been fixed to point to this bug.
Attachment #8413454 - Attachment is obsolete: true
Attachment #8413476 - Flags: review+
(Reporter)

Updated

3 years ago
Depends on: 1002297
Blocks: 942130
(Reporter)

Updated

3 years ago
Depends on: 77992
(Reporter)

Updated

3 years ago
Depends on: 1022479
(Reporter)

Updated

3 years ago
Depends on: 1024858
(Reporter)

Updated

3 years ago
Depends on: 1025768
(Reporter)

Updated

3 years ago
Depends on: 1025770
(Reporter)

Updated

3 years ago
Depends on: 1028642
(Reporter)

Updated

3 years ago
Depends on: 1028742
Blocks: 1037305
(Reporter)

Updated

3 years ago
Depends on: 1031532
(Reporter)

Updated

3 years ago
Blocks: 1031121
Depends on: 1040550
(Reporter)

Updated

3 years ago
Depends on: 1056440
(Reporter)

Updated

3 years ago
No longer depends on: 1022479
(Reporter)

Updated

3 years ago
Depends on: 1041396
Depends on: 1041374
(Reporter)

Updated

3 years ago
Depends on: 1044498
(Reporter)

Updated

3 years ago
Depends on: 1061007
(Assignee)

Updated

3 years ago
Depends on: 1062017
(Reporter)

Updated

3 years ago
Depends on: 1062055
Seeing the behaviour described in Bug 1024858, though that is marked Resolved. Can’t

Updated

3 years ago
Blocks: 1067558
(Reporter)

Comment 10

3 years ago
(In reply to John Drinkwater (:beta) from comment #9)
> Seeing the behaviour described in Bug 1024858, though that is marked
> Resolved. Can’t

Please retest with a current nightly, it should work better, although there are still bugs outstanding (see list of bugs this bug depends on).
Assignee: kinetik → nobody
(Reporter)

Updated

3 years ago
Status: ASSIGNED → NEW
(Reporter)

Updated

3 years ago
Attachment #8413476 - Attachment is obsolete: true
Attachment #8413476 - Flags: review+
(Reporter)

Updated

3 years ago
Attachment #8411549 - Flags: review+
(Reporter)

Updated

3 years ago
Attachment #8413113 - Flags: review+
(Reporter)

Updated

3 years ago
Attachment #8413454 - Flags: review+
Depends on: 1068483
No longer depends on: 1056440

Comment 11

3 years ago
See: https://bugzilla.mozilla.org/show_bug.cgi?id=1060406
Blocks: 1083588
No longer blocks: 778617
(Assignee)

Comment 12

3 years ago
Created attachment 8510663 [details] [diff] [review]
1000686.patch

Patch enables MSE for non-release builds.
Assignee: nobody → cajbir.bugzilla
Status: NEW → ASSIGNED
Attachment #8510663 - Flags: review?(ajones)
Attachment #8510663 - Flags: review?(ajones) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/918f4681e3f0
(Assignee)

Comment 14

3 years ago
Remaining open dependant bugs moved to bug 1088553.
No longer depends on: 1062055, 1068483
https://hg.mozilla.org/mozilla-central/rev/918f4681e3f0
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Was this wise? YouTube still has playback issues with WebM. None of them are tracked in the YouTube-MSE bug.

Comment 17

3 years ago
I don't know about you guys but i'm still facing several issues with the YouTube HTML5 player too (Video totally freezing, buffer stops when i'm fast-forwarding or scrolling, comment section not loading and so on.......) these issues tend to be less severe when Adblock plus is disabled BTW
(Assignee)

Comment 18

3 years ago
(In reply to Leman Bennett [Omega] from comment #16)
> Was this wise? YouTube still has playback issues with WebM. None of them are
> tracked in the YouTube-MSE bug.

If they are not tracked, we don't know about them. Please raise bugs or describe the issues, with links to videos, so we can track them down.

Updated

3 years ago
Depends on: 1089937
Depends on: 1089480
Depends on: 1089724
Depends on: 1092932
Depends on: 1135062
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.