1025874 - [GTK3] Build failure in moz_gtk_get_focus_outline_size()

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

A regression from Bug 427928

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch

w->style can't be used on gtk3. 

It comes from https://bug427928.bugzilla.mozilla.org/attachment.cgi?id=8438630

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8440666 [details] [diff] [review]
patch

Thank you.

BTW, I suspect focus_width should not be involved when interior_focus, because gtk_render_focus is not used in that case.  Also, I suspect gtk_render_frame should not be called when (!interior_focus && draw_focus_outline_only), like the gtk2 code.  But those are separate issues.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Thanks. Let's fix the build issue first.

Comment 4

[Carsten Book [:Tomcat]]

hi, could you provide a try link for this checkin ?

Comment 5

[Mike Hommey [:glandium]]

The patch touches code that isn't built by default.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/776181d387b1

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/776181d387b1