1025886 - React to the removal of ISO-2022-KR and ISO-2022-CN

Status: RESOLVED FIXED

(MailNews Core :: Internationalization, defect)

Description

[Henri Sivonen (:hsivonen)]

Bug 997115 removed ISO-2022-CN and ISO-2022-KR from mozilla-central.

comm-central should either import the code to c-c or adjust charsetalias.properties, etc., to complete the removal on the c-c side.

Bug 7965 and bug 159865 motivate the inclusion of ISO-2022-CN and ISO-2022-CN-EXT on the basis of the old Sun CDE mail client using those encodings for sending email.

For ISO-2022-KR, bug 7964 refers to unnamed legacy clients, so the case for inclusion is even less strong.

Comment 1

[Henri Sivonen (:hsivonen)]

https://groups.google.com/forum/#!topic/mozilla.dev.apps.thunderbird/2P5kCJJS_WI

Comment 2

[j.j.]

(In reply to Henri Sivonen (:hsivonen) from comment #0)

> For ISO-2022-KR, bug 7964 refers to unnamed legacy clients, so the case for
> inclusion is even less strong.

FWIW, bug 7964 comment 3 refers to a client named Netscape Communicator ...

Comment 3

[Joshua Cranmer [:jcranmer]]

(In reply to j.j. (mostly inactive) from comment #2)
> (In reply to Henri Sivonen (:hsivonen) from comment #0)
> 
> > For ISO-2022-KR, bug 7964 refers to unnamed legacy clients, so the case for
> > inclusion is even less strong.
> 
> FWIW, bug 7964 comment 3 refers to a client named Netscape Communicator ...

Added presumably in NS 4.0 (June 11, 1997) and removed by Netscape 4.5 (October 19, 1998).

I'm not sure how important 16 year old legacy archives are for support, particularly for dangerous (non-ASCII-safe) charsets like ISO-2022-*.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1025886_react_to_rem_ISO-2022-KR_and_ISO-2022-CN.patch

Sounds like we don't want to support those anymore.

Comment 5

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8526006 [details] [diff] [review]
bug1025886_react_to_rem_ISO-2022-KR_and_ISO-2022-CN.patch

Review of attachment 8526006 [details] [diff] [review]:
-----------------------------------------------------------------

There's another mention of iso-2022-kr in the MapiMessage.cpp file, but that list already contains charsets that we don't support, so we don't need to (and probably shouldn't) change that list.

Comment 6

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/06c5670de0c9 -> FIXED