1025940 - Update self.data_layer.sim_contacts to read SDN Contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Florin Strugariu [:Bebe]]

Looks like now we are Importing SDN (Service Dialing Numbers) contacts
Bug 876632 - [User Story] Service numbers (SDN) not imported from the SIM 

So our atom should import those contacts too.

Let's update the atom

Comment 1

[Zac C (:zac)]

Here is the code for getting the contact type:
http://dxr.mozilla.org/mozilla-central/source/dom/webidl/MozIcc.webidl#352

It looks like there's no 'all' option so we'll have to readContacts for 'adn' and 'sdn' and merge the results together before the callback.

Comment 2

[Florin Strugariu [:Bebe]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20686

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8442039 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20686

Just one nit with the argument name, but otherwise this looks good to me. I haven't tested it though.

Comment 4

[Zac C (:zac)]

Comment on attachment 8442039 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20686

I can only f+ as I don't have an sdn contact on my SIMs :(

Comment 5

[Florin Strugariu [:Bebe]]

Dave pull updated

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8442039 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20686

Normally I don't need to review again if all you've done is address the nit. You can just carry my review forward. However, you've gone and changed more than you needed here. See the pull request comment, but now this is a r-.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8442039 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20686

Okay, looks good now. Thanks!

Comment 8

[Viorela Ioia [:viorela]]

Comment on attachment 8442039 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20686

lgtm

Comment 9

[Viorela Ioia [:viorela]]

Comment on attachment 8442039 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20686

r+

Comment 10

[Viorela Ioia [:viorela]]

Merged: https://github.com/mozilla-b2g/gaia/commit/39b5929c8bec26e28fd1c4cc5f0b320887c1f5d4

Comment 11

[Viorela Ioia [:viorela]]

We need this for v2.0 too

Comment 12

[Zac C (:zac)]

Landed on v2.0
https://github.com/mozilla-b2g/gaia/commit/00bdc43e4512da9409575593a0dcaafee0ee74f4