876632 - [User Story] Service numbers (SDN) not imported from the SIM

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Juan Perez-Bedmar [:juanpbf]]

When importing SIM contacts, the Service Dialing Numbers (SDN) are not imported and they should.

Reproducible in Ikura with any build

shall we nominate it for leo? --> what do you think David?

Comment 1

[David Palomino [:dpalomino]]

Hi!

I think this is not a blocking issue for 1.0.1. Preloaded contacts are preloaded in the commercial devices, so it should be not very important. 

Thanks!
David

Comment 2

[David Palomino [:dpalomino]]

I think this could be included for leo. Nominating it.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Could be included makes this sound like additional feature work and too late for v1.1 - if this is not championed by a partner and assigned a milestone it will have to wait for a future release.

Comment 4

[Juan Perez-Bedmar [:juanpbf]]

This issue has come back to light during the official IOT for Open C -- The operator has reported it again. 

What's current status? Is this going to be included in 1.3? if not, can we nominated it at least for 1.4?

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

I have a quick question, when we are suppose to import SDN contacts?

As an option form the import menu, we import them when user clicks on import contacts from sim (importing both ADN and SDN)?

Flagging Mr Wildfred for some input

Comment 6

[Wilfred Mathanaraj [:WDM]]

this is what would make sense if we need to import SDN. When we import contacts from SIM it should then import ADN, SDN all normal contacts.

Comment 7

[David Scravaglieri [:scravag]]

Could be landed until March 17th if ready, not a release blocker

Comment 8

[Fernando Campo (:fcampo)]

I've been testing this, but due both to lack of information (no documentation on the function we need to call from mozContacts or icc, neither on wiki or mdn) and not having a SIM with sdn contacts inside, I'm gonna keep it aside till next week, when I'll try to get my hands on it.

Comment 9

[Noemí Freire (:noemi)]

We would need input about how SDN contacts should be managed (specific list?, part of the contact list?), asking UX for their PoV (spec). Thanks!

Comment 10

[ayman maat :maat]

(In reply to Noemí Freire (:noemi) from comment #9)
> We would need input about how SDN contacts should be managed (specific
> list?, part of the contact list?), asking UX for their PoV (spec). Thanks!

Well, the design intention behind this has always been that *all* contacts could be imported from SIM. On my test SIMs the SDNs are part of the Contact List with no structural distinction between them and other contacts which is why there was never any specific reference to SDNs in the specification.

If there are instances were SDNs exist as a separate list to the Contact List on a SIM and therefore should exist as a separate list on the device please advise me of how this is expected to work (presentation of SDN on SIM, during import and when the SDN are on the phone itself) and I will define and produce a specification accordingly. Screenshots or video would be good. Please ni? me if any are forthcoming

Comment 11

[zhangdapeng]

the SDN list shouled be managed as part of the contact list
but now the question is the sim card has SDN  but did not display in the contact list

Comment 12

[Jason Smith [:jsmith]]

Not a regression, so this is should not block 1.3.

Comment 13

[zhangdapeng]

can this problem be solved recently?

Comment 14

[Noemí Freire (:noemi)]

Hi Carrie,

Could you please provide UX interaction flow here?. Thanks!

Comment 15

[Carrie Wang [New account: [e-mail]]]

I think for this bug, we shall let users import both SDN and ADN with other contacts for now. We shall display these numbers with normal contacts and let users filter their preferred/ important contacts from this long list in the future (could be added into future plan). Thanks!

Comment 16

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

feature of 2.0 needs to be landed before FL (Sprint3)

Comment 17

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Comment 18

[Jose Manuel Cantera]

Comment on attachment 8431446 [details] [review]
patch v1.0

as we have talked offline we need to refine a bit more the solution, so let's cancel the review for the moment.

Comment 19

[Jose Manuel Cantera]

Comment on attachment 8431446 [details] [review]
patch v1.0

The only thing I'm missing is a test that checks whether the importer.onerror is called when the request for ADN Contacts is on error. Please add it and land when Travis is green

Comment 20

[Marina Rodríguez [:mai]]

Master: 6a083e741bdf945bbdff32edb78ce7476199128a

Comment 21

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
2.0
Platform versión 32.0a1
Build ID: 20140606084902
Git commit: 902b0cdf

Comment 22

[Maria Angeles Oteo (:oteo)]

Updating the title as this bug is a User Story and including also the ACs agreed with UX during the implementation. 

QA already verified this US based on them during last week so the corresponding bugs should be exported in Moztrap.

Comment 24

[xianxian.lv]

attachment 8431446 [details] [review] pacth is united, but doesn't work, could you tell me the verified，need to support

Comment 25

[Beatriz Rodríguez [:brg]]

We had tested master-Flame, today build, and the import of ADN and SDN numbers is working fine. If you had any issue here, please open a new bug and provide more info about your testing environment.

Comment 26

[xianxian.lv]

I will open a new bug for you,We think FireFox can support SDN UI , SDN can be found under Settings->Call Settings->Operator Service
(at the bottom of the menu).