1026005 - Create AsyncTaskLoader for querying/updating Fennec Accounts status

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

This is the Fragment-centric way to establish and update UI in response to accounts coming, going, and changing status.

Comment 1

[Nick Alexander :nalexander [he/him]]

This is needed in the Fennec UI (for the Remote Tabs panel), but also in the background services UI (for basically all activities, eventually).  Therefore we'll implement in android-sync, but expose in the FirefoxAccounts module.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/465

rnewman: your queue is long.  Maybe delegate to mcomella?  Or some other front-end person who would know about loaders?

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8440816 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/465

It's review day for mcomella.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8440816 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/465

Comments on github.

Comment 5

[Mark Capella [:capella]]

nalexander (and anyone keeping score): checking status ...

In our etherpad discussion (https://mobile.etherpad.mozilla.org/remote-tabs-home-panel?), you mention a loader wip for this bug ... I don't use / am unfamiliar with git as a matter of course, but I'm assuming you're referring to these two changesets, and that the others were handled in their respective bugzillas:

https://github.com/mozilla-services/android-sync/commit/b4a848111c6d6c6229d323bbb69e52af2eb189ec
https://github.com/mozilla-services/android-sync/commit/17c3ed2b7a41fe7f19d464c90b19c620af1f0509

Also, in the etherpad you mentioned wanting to do (a third?) bit:

   "The states that the account can be in are the members of Action: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/fxa/login/State.java#22.  I'd like to move that enum into FirefoxAccounts.java (it's part of the contract between background services and Fennec)"

Would that be part of this patch? Should I open a new one?

I'm trying to get a handle around each puzzle piece. Some of the planning/direction under Meta Bug 1002573 - "Improve Fennec's Remote Tabs panel" seems to be cross bleeding, and I like to avoid scope-creep  :-)

Comment 6

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/465

This is about as long as I've taken to get to a review, I think :)  Thanks for catching that thread handling issue!

Comment 7

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8474906 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/465

r=mcomella via github and IRC.

Comment 8

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/61418463b998

Comment 9

[Nick Alexander :nalexander [he/him]]

Bustage follow-up:

https://hg.mozilla.org/integration/fx-team/rev/e03842f0980f

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/61418463b998
https://hg.mozilla.org/mozilla-central/rev/e03842f0980f