Closed
Bug 1026123
Opened 10 years ago
Closed 10 years ago
add-on debugging checkbox should be spelled "add-on", not "addon"
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: MattN, Assigned: MattN)
References
Details
Attachments
(1 file, 1 obsolete file)
1.99 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
We're supposed to use "add-on" everywhere facing users, not "addon". I also fixed the name of the Add-ons Manager. Axel, since I'm not changing the meaning, only changed pre-defined terms, is it fine that I don't change the entity names?
Attachment #8440905 -
Flags: review?(l10n)
Attachment #8440905 -
Flags: review?(jsantell)
Updated•10 years ago
|
Attachment #8440905 -
Flags: review?(jsantell) → review+
Comment 1•10 years ago
|
||
Comment on attachment 8440905 [details] [diff] [review] v.1 "addon" => "add-on" and "Add-on Manager" => "Add-ons Manager" Review of attachment 8440905 [details] [diff] [review]: ----------------------------------------------------------------- This is OK from an l10n POV. We're a bit inconsistent of Add-on vs add-on, we kinda use both across our code, it seems.
Attachment #8440905 -
Flags: review?(l10n)
Attachment #8440905 -
Flags: review?(jsantell)
Attachment #8440905 -
Flags: review+
Comment 2•10 years ago
|
||
Comment on attachment 8440905 [details] [diff] [review] v.1 "addon" => "add-on" and "Add-on Manager" => "Add-ons Manager" Review of attachment 8440905 [details] [diff] [review]: ----------------------------------------------------------------- acting mossop acting jsantell
Attachment #8440905 -
Flags: review?(jsantell) → review+
Comment 3•10 years ago
|
||
Won't the entity names need changed? https://developer.mozilla.org/en-US/docs/Making_String_Changes
Assignee | ||
Comment 4•10 years ago
|
||
See comment 0 and comment 1 about the entity name.
Attachment #8440905 -
Attachment is obsolete: true
Attachment #8440927 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1f43eaf16bd2
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 6•10 years ago
|
||
Consistency is actually pretty good, also because we usually file bugs when we see "addon" (must have missed this) http://transvision.mozfr.org/?recherche=addon&repo=central&sourcelocale=en-US&locale=en-US&search_type=strings Note also that the MDN page has been integrated in a much larger page about l10n best practices https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Changing_existing_strings
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1f43eaf16bd2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•