1026162 - (asan-macbuilds) Automate Mac ASan builds and make them publicly available (like Linux builds)

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Steven Michaud [:smichaud] (Retired)]

Current documentation on ASan builds is here:
https://developer.mozilla.org/en-US/docs/Mozilla/Testing/Firefox_and_Address_Sanitizer

As this doc says, nightly Linux trunk ASan builds are currently available.  But this isn't yet true for Mac builds.

Currently I'm doing Mac ASan builds "by hand", about once a week, and am making them available here:

http://people.mozilla.org/~stmichaud/bmo/firefox-asan.dmg

Instructions for how I do these builds are available here:

http://people.mozilla.org/~stmichaud/bmo/firefox-asan-howto.txt

But these builds should really be automated and done nightly, like the Linux builds.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

In the week since my "hand made" builds were first available, they've been instrumental in finding three bugs, two of which are security-sensitive.  So Mac ASan builds are clearly useful.

Automating these builds (and making them publicly available as nightlies) will enhance their usefulness, increase the number of users, and presumably increase the number of bugs found.

Comment 2

[Al Billings [:abillings - ex-MoCo]]

Who can we assign this to?

Comment 3

[Gregory Szorc [:gps]]

This is a release engineering bug as opposed to a core build system bug.

Comment 4

[Christian Holler (:decoder)]

I can certainly help with some of the TODOs here, especially getting the newer Clang to work. But I'd have to get a Mac for this, I assume. And we should make it part of the Q3 goals then.

Comment 5

[Steven Michaud [:smichaud] (Retired)]

> especially getting the newer Clang to work

I've had much better luck with LLVM revision 208032 (which I *think* corresponds to the 3.4.1 release) than with 200213.  But use of 208032 is currently blocked by bug 982693.

With both 200213 and 208032, you need to add the following cmake parameter to build llvm successfully on OS X 10.7:

-DLLVM_ENABLE_LIBCXX:BOOL=ON

Comment 6

[Christian Holler (:decoder)]

Thanks, that valuable information Steven :)

If 208032 works better, we might as well target that version for the next ASan Clang upgrade, also on Linux :)

Comment 7

[Steven Michaud [:smichaud] (Retired)]

Attachment: firefox-asan-howto.txt

I'm going to be retiring in the next few months, and my people.mozilla.org account will presumably disappear.  In anticipation of that (and in case I forget), I'm attaching the latest revision of my instructions for doing a Mac ASan build "by hand".

I'm no longer doing these builds -- I stopped some months ago.

Comment 8

[Jonathan Watt [:jwatt]]

FWIW I think this is now unblocked. I can create local ASan builds on Mac without issue.

Comment 9

[Jesse Schwartzentruber (:truber)]

Done in 1421728.

Fuzzing ASan builds are now available from taskcluster, eg. latest: https://tools.taskcluster.net/index/gecko.v2.mozilla-central.latest.firefox/macosx64-fuzzing-asan-opt