Closed Bug 1026300 Opened 5 years ago Closed 5 years ago

Add Twitter logo to search plugin so about:newtab can use it

Categories

(Firefox :: Search, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 33
Tracking Status
firefox30 --- unaffected
firefox31 --- verified
firefox32 --- verified
firefox33 --- verified

People

(Reporter: adw, Assigned: adw)

References

Details

(Whiteboard: p=1 s=33.1 [qa!])

Attachments

(1 file)

Attached patch patchSplinter Review
(In reply to Joanne Nagel from bug 1006203 comment #15)
> As we discussed previously, I don't have agreements with Twitter or
> Wikipedia, so we should be able to use whatever assets they have published
> online.

This patch uses the images Boriss posted to bug 962490 comment 34.

Matt, this patch is similar to the one you reviewed in bug 1009299.
Attachment #8441070 - Flags: review?(MattN+bmo)
Marco, could we add this to the current iteration, please?
Flags: needinfo?(mmucci)
Flags: firefox-backlog+
Whiteboard: p=1
Added to Iteration 33.1
Flags: needinfo?(mmucci)
Whiteboard: p=1 → p=1 s=33.1 [qa?]
Attachment #8441070 - Flags: review?(MattN+bmo) → review+
Whiteboard: p=1 s=33.1 [qa?] → p=1 s=33.1 [qa+]
https://hg.mozilla.org/mozilla-central/rev/9f240286039b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
QA Contact: petruta.rasa
Verified as fixed on latest Nightly 33.0a1 2014-06-18 under Win 7 64-bit, Ubuntu 12.10 32-bit and Mac OSX 10.8.5.
The logo appears and works as expected.

Shouldn't this be uplifted to Aurora and Beta as the main feature is already in beta, ready for release?
Status: RESOLVED → VERIFIED
Whiteboard: p=1 s=33.1 [qa+] → p=1 s=33.1 [qa!]
Comment on attachment 8441070 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Bug 962490 added a search field to about:newtab and landed on 31.  The logo of the currently selected search engine, if available, appears to the left of the search field.

User impact if declined:
When Twitter is the currently selected engine, its logo will not appear.  about:newtab gracefully handles missing logos, though.

Testing completed (on m-c, etc.):
manual testing, automated testing on m-c

Risk to taking this patch (and alternatives if risky):
very low

String or IDL/UUID changes made by this patch:
none
Attachment #8441070 - Flags: approval-mozilla-beta?
Attachment #8441070 - Flags: approval-mozilla-aurora?
Attachment #8441070 - Flags: approval-mozilla-beta?
Attachment #8441070 - Flags: approval-mozilla-beta+
Attachment #8441070 - Flags: approval-mozilla-aurora?
Attachment #8441070 - Flags: approval-mozilla-aurora+
Whiteboard: p=1 s=33.1 [qa!] → p=1 s=33.1 [qa+]
Verified as fixed using Firefox 31 beta 3 and latest Aurora 32.0a2 20140622004004 under Win 7 64-bit, Ubuntu 13.04 64-bit and Mac OSX 10.9.2.
Whiteboard: p=1 s=33.1 [qa+] → p=1 s=33.1 [qa!]
You need to log in before you can comment on or make changes to this bug.