71.16 KB, image/png
33.40 KB, image/png
19.25 KB, image/png
47.01 KB, image/png
46 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
Created attachment 8441204 [details] TextHighlightFlame.png ### STR 1. Have some missed entries call log. 2. Go to Missed tab. 3. Enter Edit mode, and leave by tapping the X. Do not delete anything. https://www.youtube.com/watch?v=e2dAGVhhHns ### Actual result 1. 'Missed' has black highlight 2. See TextHighlightFlame.png TextHighlightBuri.png ### Expected result 1. Text label dont change. ### Version Flame aurora v2.0 Gaia 0f254c92bc44d614ae56a855f18a895a7e4703ad Gecko https://hg.mozilla.org/releases/mozilla-aurora/rev/301e62e44f18 BuildID 20140616160201 Version 32.0a2 ro.build.version.incremental=109 ro.build.date=Mon Jun 16 16:51:29 CST 2014 t2m.sw.version=B1TC00011220 Buri aurora v2.0 Gaia 0f254c92bc44d614ae56a855f18a895a7e4703ad Gecko https://hg.mozilla.org/releases/mozilla-aurora/rev/301e62e44f18 BuildID 20140616160201 Version 32.0a2 ro.build.version.incremental=324 ro.build.date=Thu Dec 19 14:04:55 CST 2013
Summary: [Dialer][Call Screen] Some characters of name truncated in call sceen → [Dialer][Call log] 'missed' highlighted when tapping edit and back, then tapping 'all'
Hi, Etienne, Could you help to check this weird highlight, thank you.
Hey German, looks like a visual refresh follow up. Maybe just adding a |-moz-user-select: none;| will be enough :)
Flags: needinfo?(etienne) → needinfo?(gtorodelvalle)
blocking-b2g: 2.0? → 2.0+
Keywords: regression, regressionwindow-wanted
Created attachment 8443328 [details] [review] patch in github
Attachment #8443328 - Flags: review?(arnau)
Comment on attachment 8443328 [details] [review] patch in github Thanks Paco! I cannot reproduce that anymore after your patch :)
Attachment #8443328 - Flags: review?(arnau) → review+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Clearing German's ni as the issue is solved ;)
status-b2g-v2.0: affected → fixed
Reverted for causing bug 1029567, [B2G][Browser]Typing in a web address opens a blank white page. Perhaps the browser is not using these building blocks the proper way? Master: https://github.com/mozilla-b2g/gaia/commit/2cede10a3f31d8734da193a4d16c3dbb8a751e6a 2.0: https://github.com/mozilla-b2g/gaia/commit/9685d84f016e370f67a80be6b32045f5cabf7a87 Paco - could we by chance get a call-log specific patch, or another patch that does not break browser? Thanks!
Status: RESOLVED → REOPENED
status-b2g-v2.0: fixed → affected
status-b2g-v2.1: fixed → affected
Resolution: FIXED → ---
Flagging NO_UPLIFT for being the root cause of a smoketest, so this has to get approval to land.
It also looked like this one caused some problems with the email app as noted in bug 1029567. Just making a note that we should check that before landing again.
This change affected email so badly because .bb-tablist has a height: 100% on it. However, the ul for that list of buttons on the bottom of the message list and message reader is just one part of the UI, just used for the bottom row of buttons, and there are other sibling elements above it for the message contents. By changing the height: auto for .bb-tablist in the shared tabs.css, that seemed to work better -- the ul did not take up the full screen, just the size of the bottom buttons. When the background for .bb-tablist was changed to white and with a height of 100%, that meant it covered up the email contents, since the ul was the higher z order element. It is unclear to me why .bb-tablist needs to be height 100%, but if this white background is needed, it may be worth revisiting why the height needs to be 100%.
Created attachment 8445599 [details] EmailLoadingMessagesWithBlackSquare.png Yes, I saw this in email, but unable to figure out the exact STR. And settings as well, saw this in bluetooth menu. (In reply to Kevin Grandon :kgrandon from comment #11) > It also looked like this one caused some problems with the email app as > noted in bug 1029567. Just making a note that we should check that before > landing again.
Created attachment 8445608 [details] SettingsTextHighlighted-2.png Bluetooth in Settings affected as well, no exact STR.
Created attachment 8446372 [details] [review] patch in github
We have changed the background for affecting only on filters. Now, the problems on browser and email should be disappear. Could you check?
Comment on attachment 8446372 [details] [review] patch in github Regressions in the previous bug were caused in apps were .bb-tablist was not properly used. Unfortunately Tabs BB is not one of the best components we have, we will probably have a better solution when using web components. New Paco's patch applies the background only to filters (.bb-tablist[data-type="filter"]) So now white screens are not appearing anymore. Sorry for the inconveniences in the regression as I did not checked email app (just call log, calendar, clock and music) and was not expecting that behavior in browser app.
Attachment #8446372 - Flags: review?(arnau) → review+
Jason, Eric, can Arnau land the patch in master so you can test there is no regressions in that branch before doing the uplifting to 2.0 or do you want to test the patch before?
(In reply to Maria Angeles Oteo (:oteo) from comment #19) > Jason, Eric, can Arnau land the patch in master so you can test there is no > regressions in that branch before doing the uplifting to 2.0 or do you want > to test the patch before? That works for me.
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago → 4 years ago
Resolution: --- → FIXED
(In reply to Jason Smith [:jsmith] from comment #20) > > That works for me. Thanks Jason, setting "verifyme" so QA can confirm that the bug is resolved and no more regressions raise before uplifting to 2.0
Harvey, can you confirm all is ok, so we can remove the [NO_UPLIFT] whiteboard and allow the uplifting to 2.0, thanks a lot!
Switching needinfo to the lead to have someone from the smoke team look at this.
Flags: needinfo?(jharvey) → needinfo?(pbylenga)
Already have the info on the master build encase this is useful. I am unable to reproduce this issue on the latest Flame Master build. Environmental Variables: Device: Flame Master Build ID: 20140629193729 Gaia: de14e61098b742251b34f856e48649db8bed552c Gecko: b6408c32a170 Version: 33.0a1 (Master) Firmware Version: v122
QA Whiteboard: [QAnalyst-Triage?]
I can verify this as fixed, for the white page regression I checked Browser, Call logs, Email, Calendar, Music, Clock, Bluetooth menu, Developer Options, and Contacts. Environmental Variables: Device: Flame Master Build ID: 20140630040201 Gaia: de14e61098b742251b34f856e48649db8bed552c Gecko: b6408c32a170 Version: 33.0a1 (Master) Firmware Version: v122
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
status-b2g-v2.1: fixed → verified
status-b2g-v2.0: affected → fixed
Verified okay with these 2 builds. Flame - aurora - v2.0 Gaia e935f4ff190b76c70d9b2af8856c542a6e4a7546 Gecko https://hg.mozilla.org/releases/mozilla-aurora/rev/3f9d7a3a0b7b BuildID 20140707160206 Version 32.0a2 ro.build.version.incremental=109 ro.build.date=Mon Jun 16 16:51:29 CST 2014 B1TC00011220 Flame - master - v2.1 Gaia 1dc9e53393ae4680a174dffa44a958ec564ebbe8 Gecko https://hg.mozilla.org/mozilla-central/rev/dfef245594b6 BuildID 20140707160202 Version 33.0a1 ro.build.version.incremental=109 ro.build.date=Mon Jun 16 16:51:29 CST 2014 B1TC00011220
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.