1026431 - [Text Selection] Selection carets display as tilt mode when selectall.

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

When selectall, the range's StartParent and EndParent will be parent element node instead of text node. In this case, we switch our carets to tilt mode [1]. We should modify this condition to avoid this issue.

[1] http://dxr.mozilla.org/mozilla-central/source/layout/base/SelectionCarets.cpp?from=SelectionCarets.cpp&case=true#460

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1026431

In this case <textarea>abc</textarea> and we select 'c' character,
EndContent would be HTMLDivElement and mResultContent which get by
calling startFrame->PeekOffset() with selecting next cluster would be
TextNode. Although the position is same, nsContentUtils::ComparePoints
still shows HTMLDivElement is after TextNode. So that we cannot use
EndContent or StartContent to compare with result of PeekOffset().
So we compare between next charater of startFrame and previous character
of endFrame.

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1026431 v2

Check mResultContent before calling ComparePoints

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

try push: https://tbpl.mozilla.org/?tree=Try&rev=c41d0823bbcf

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c7494103b4c7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c7494103b4c7