1026690 - Highlight actionable Fields

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Comment 1

[Julien Wajsberg [:julienw]]

Wilfred, can you please be clearer about which fields are confusing right now?

Comment 2

[Wilfred Mathanaraj [:WDM]]

the items are not very specific to an item/screen - this should be addressed as part of the visual refresh items. the ux team should be able to define something that resolves some of these items.

Comment 3

[Carrie Wang [New account: [e-mail]]]

Attachment: [2.1 Contacts] Actionable field - Contact Edit page redesign.pdf

Hi, the attached spec is related to the actionable fields in Contact edit page. Thanks!

Comment 4

[Julien Wajsberg [:julienw]]

Hey Carrie, I think it's the wrong bug. This bug is for Gaia::SMS.

So either this bug should really be for Contacts, or there is a separate bug for Contacts :)

Comment 5

[Carrie Wang [New account: [e-mail]]]

I think both SMS and Contacts received this user story and this is the bug which is pointed from backlog. I think we shall separate them and also provide a specific name for the feature. Can I do it myself or shall I leave this to product? Thanks!

Comment 6

[Wilfred Mathanaraj [:WDM]]

Carrie - you can call it what you want - as long as it relates back to this bug.

Comment 7

[Julien Wajsberg [:julienw]]

So if I understand correctly, we could do 2 dependent bugs for SMS and Contacts, and we don't have the spec for SMS yet. Is that correct Carrie?

Comment 8

[Carrie Wang [New account: [e-mail]]]

I think Jenny did some design improvement on this user story. ni? her here.
And yes, we need to separate these two APPs. I'll create a new bug for Contacts APP.

Comment 9

[Julien Wajsberg [:julienw]]

NI Jenny on this story for SMS then. Thanks !

Comment 10

[Jenny Lee]

Attachment: [2.1 Message] Highlight actionable area v1.0.pdf

Hello! There are two issues described in the spec. The first is about the actionable area of composer seems a bit vague and this requires VD's work; the second is about removing the "tap on a contact to see more option on message report page" function (Note that I am working on a new design for message report, it shall be ready soon) Thanks!
  
ni Fang for visual. Hello Fang, could you check on this? Thanks!

Comment 11

[Julien Wajsberg [:julienw]]

(In reply to Jenny Lee from comment #10)
> Created attachment 8461328 [details]
> [2.1 Message] Highlight actionable area v1.0.pdf

Hey Jenny,

> 
> Hello! There are two issues described in the spec. The first is about the
> actionable area of composer seems a bit vague and this requires VD's work;

In the "New message" panel, we can actually tap anywhere in the white space to focus the composer. It was done during the refresh: before the refresh (so before v2.0), we could only tap the composer itself and it actually had a border.

Now everything should happen as if the whole white space is actually the composer.

I'm not so sure of this in the "Thread" panel though, maybe _this_ panel would need adjustments.

What are your thought about this?


> the second is about removing the "tap on a contact to see more option on
> message report page" function (Note that I am working on a new design for
> message report, it shall be ready soon) Thanks!

This always felt weird to me too, so I'm with you here :)

Comment 12

[Jenny Lee]

Hello Julien, ohhhh I didn't realize it is intended that way.. but from what I know, in the latest design, there will be background color for the white space we have now, so the different touch areas of recipient field, conversation history (or white space if it's a new message) and composer will be clear. Hence the tap-on-white-area-to-focus-on-composer behavior will no longer exist. Thanks ;)

ni Fang on this for visual.

Comment 13

[Julien Wajsberg [:julienw]]

Ok, let's see what Fang will do.

I'm not against this, it's just that it's work that we do this first and then remove it, in 2 successive versions, for no more apparent reason that we change the design masters.

Comment 14

[Fang Shih [:fang]]

Attachment: SMS_VisualSpec_0731.zip

Attached some spec that included thread panel and compose view. 
We've added a light minty green in conversation background, this should able to fix the problem. Thanks!

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Just one little thing, I put a dependency with bug 1048159 to solve the contacts part on this one.

Comment 16

[Eric Chang [:ericcc] [:echang]]

[Comms][Messages]Small set
https://moztrap.mozilla.org/manage/suites/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-name=%5Bcomms%5D&filter-name=messages&filter-name=small

Comment 17

[Julien Wajsberg [:julienw]]

(remaining work is in Contacts, moving components to make things clearer)

Comment 18

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

setting target to sprint3 for the meta bug. 
Dependent bugs are not all feature-b2g=2.1. 
If those are not being landed in 2.1, we should create another meta "[improvement] highlight actionable field" and still close this one after FL.

Comment 19

[Francisco Jordano [:arcturus] [:francisco]]

All work done, so marking as fixed :D

Comment 20

[Loli (:lolimartinezcr)]

Tested and working
Flame
2.1
Gecko-4d85c35
Gaia-561f053

Comment 21

[Loli (:lolimartinezcr)]

(In reply to Loli (:lolimartinezcr) from comment #20)
> Tested and working
> Flame
> 2.1
> Gecko-4d85c35
> Gaia-561f053

Sorry, I change to "resolved". This comment isn't for this bug and Im not QA Contact

Comment 22

[Fred Muyumba [:FredM]]

This issue is verified fixed on Flame 2.1(319mb) 

Flame 2.1(319mb)

Environmental Variables:
Device: Flame 2.1 (319mb)
Build ID: 20140903000204
Gaia: fbb297c39aab5f17b179533d2a9a6c5166b2c197
Gecko: fb5e796da813
Version: 34.0a2 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

STR: 
1: Launch "Messages" App
2. Tap on "New" message
3. Add recipient
4. Type message in "Message" text box
5. Observe "Send" button

Actual Result: "Send" button is only actionable (receives focus) when the message is ready as expected

Comment 23

[KTucker [:KTucker][Inactive 3/4/2016]]

Please ignore comment 22

Contacts app and messages apps for the most part match design docs.
 
When composing a new SMS, the composer expands properly when there is no subject.

The subject line will stick to bottom of the to: field as composer expands. The composer sticks to the bottom of the subject line. 

In delivery reports, contacts are no longer clickable. 

------------------------------------------------------------------------------------

However, I cannot verify this issue as fixed because of these 3 issues:

When adding two attachments such as a picture and music to the same SMS that the top attachment is not aligned left but instead aligned to the right. This is incorrect according to this document:

MessagingThread_VisualSpec.002.png

The issue has been written bug 1062634

Country and date fields are not automatically filled with the default country and default date as stated in this document:

2.1_Add_Contact_VisualSpec.002.png

This has been written bug 1063060

Multiple headers including the delivery report header act like they are clickable when tapped. 

This issue has been written bug 1063123

Comment 24

[Jason Smith [:jsmith]]

The three issues cited above aren't blockers, so I don't think they should block verification of this feature.

Comment 25

[KTucker [:KTucker][Inactive 3/4/2016]]

As stated by Jason the 3 issues are not blockers so this has been verified as fixed on the Flame 2.1(319mb) and Flame 2.2(319mb)

Flame 2.2

Environmental Variables:
Device: Flame Master (319mb)
Build ID: 20140908040204
Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Gecko: 892768985915
Version: 35.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1

Environmental Variables:
Device: Flame 2.1(319mb)
Build ID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Recipient list is no longer clickable in delivery message reports. 

Message box has a clear border now and the send icon highlights blue to indicate that the item is actionable when the to: and message fields are filled out.