1026705 - [B2G][Flame][Camera] Audio for video is recorded on Flame with front microphone making it difficult to pick up sound

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Vendcom, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Description:
When user records video with camera on Flame device the audio is being recorded with the microphone located on the bottom of the phone near the front face. The microphone on the back face of the phone is not used. Because of this the audio for videos is difficult to hear.


Repro Steps:
1) Update a Flame to 20140617040203
2) Launch Camera app
3) Toggle switch to record video
4) Record video with sound in the environment
5) Play recorded video

Actual:
Audio is difficult to hear.

Expected:
Audio can be heard clearly.

Environmental Variables:
Device: Flame 2.1
Build ID: 20140617040203
Gaia: eac13407742a55b11e1877b4df2abdfd22cd582e
Gecko: bb35d1b73634
Version: 33.0a1  
Firmware Version: v121-2

User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Notes:
Repro frequency: 3/3, 100%
See attached: Youtube video clip & logcat
Youtube link: http://youtu.be/hSq5LvjxWe8
Note: Youtube video is taken with rear-facing camera

Comment 1

[Brogan Zumwalt [Inactive]]

QA Wanted to test on other branches and devices

Comment 2

[Brogan Zumwalt [Inactive]]

Issue not tested on Buri, Open C, or Tarako as these devices lack a back facing microphone

Issue DOES reproduce on Flame 2.0 and Flame 1.4

Environmental Variables:
Device: Flame 2.0
Build ID: 20140617000201
Gaia: 0f254c92bc44d614ae56a855f18a895a7e4703ad
Gecko: 7f309a3a4d3d
Version: 32.0a2 (2.0) 
Firmware Version: v121-2

Environmental Variables:
Device: Flame 1.4
Build ID: 20140617000202
Gaia: 4b3428e85b428e577a0f96cba6121c4ca1c91f8a
Gecko: ba55b5a7b20d
Version: 30.0 (1.4) 
Firmware Version: v121-2

Actual Results: Audio from rear facing camera is very difficult to hear in recorded video

Leaving QA Wanted to test on Flame base builds

Comment 3

[Brogan Zumwalt [Inactive]]

Issue DOES occur on v10G-2 Flame Base and v10F-3 Flame Base

Environmental Variables:
Device: Flame 1.3
Build ID: 20140520094859
Gaia: a73235d23685e9898f40647cebd83b3fcbfd0117
Gecko: b637b0677e15318dcce703f0358b397e09b018af
Version: 28.0 (1.3) 
Firmware Version: v10G-2

Environmental Variables:
Device: Flame 1.3
Build ID: 20140505215459
Gaia: ec462dc62979dae593b4ad96ac3851ccbafe1813
Gecko: b637b0677e15318dcce703f0358b397e09b018af
Version: 28.0 (1.3) 
Firmware Version: v10F-3

Actual Results: Audio from rear facing camera is very difficult to hear in recorded video

Comment 4

[Joshua Mitchell (Inactive)]

Relevant Branch-checking complete and NOT a regression

Comment 5

[Jean Cayron]

I don't know if that bug is related: #845662

I have a similar problem with GP Peak 1.1/1.3/2.0/2.1: the microphone works well to phone but on the videos and for the sound recorder, the sound is very ****. Maybe does it use the front microphone.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Sotaro-san, is there any way we can get better logging to see if it's a device or a gonk/gecko issue?

Comment 7

[Sotaro Ikeda [:sotaro]]

Tomorrow, I am going to take a look.

Comment 8

[Sotaro Ikeda [:sotaro]]

It is a android(gonk)'s limination. gecko does not have a way to choose mic from candidates directly. gecko can only set audio source type. AUDIO_SOURCE_CAMCORDER is used on camcorder case.

gecko set audio source as AUDIO_SOURCE_CAMCORDER, when recording video of camera. It is same to android. Android always use AUDIO_SOURCE_CAMCORDER as audio source for camera recording. And android does not provide a way to choose input audio directly. Instead, AudioPolicyManager does choose the input device.
AudioPolicyManager::getDeviceForInputSource() does it.

Until android KK, input choose logic was in platform hal code. On anroid L, the logic was moved to android platform codde. But even in L, only AudioPolicyManager can choose the input audio device from audio source type.

The following is getDeviceForInputSource() of caf code of KK
https://www.codeaurora.org/cgit/external/gigabyte/platform/hardware/qcom/audio/tree/policy_hal/AudioPolicyManager.cpp?h=caf/b2g_kk_3.6#n825

The following is getDeviceForInputSource() of android aosp code of L
http://androidxref.com/5.1.1_r6/xref/frameworks/av/services/audiopolicy/AudioPolicyManager.cpp#5191

Comment 9

[Sotaro Ikeda [:sotaro]]

When AUDIO_SOURCE_CAMCORDER is requested as audio input, AudioPolicyManager choose back mic it it exist. If it does not exist, AudioPolicyManager choose default built in mic.

Comment 10

[Sotaro Ikeda [:sotaro]]

This situation might be changed in android M or next. android M seems to add more control capability to audio input. It is in the following.
   http://developer.android.com/preview/api-overview.html#audio

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Based on this, this seems like a won't fix until we go to M.

Ken, FYI.  It looks like in order to fix some bugs we are dependent on the gonk layer.

Comment 12

[Ken Chang[:kenkai]]

Hi Blake, can you check who from you team to look into this bug.

Comment 13

[Blake Wu [:bwu][:blakewu]]

From comment 8 ~ 10, I also think we may need to wait Android M. Not sure we could create our way (modify the gonk) to select the MIC we want. 
Ni Munro to see if he has other ideas.

Comment 14

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Didn't find this issue on aries-kk, whose behavior is as expected: it records the sound from front & back mic in parallel and put them to the two audio channels respectively.
On flame, two audio channels are exactly the same, which are both from the front mic.
I will check the problem further, probably in the gonk.

Comment 15

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

This stereo audio recording is implemented in audio hal (partner's implementation)
Take aries-kk as example, audio policy manager set the source to back mic, but actually the underlying audio hal enables 2 mic and deliver a real stereo pcm.
If we want to have this feature on flame, we need to request partner to enable this feature.

Comment 16

[BMO Automation]

Firefox OS is not being worked on