Closed Bug 1027057 Opened 6 years ago Closed 6 years ago

Panel animations have wrong anchor in RTL mode

Categories

(Firefox :: Toolbars and Customization, defect)

33 Branch
x86
All
defect
Not set
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 33
Iteration:
33.3

People

(Reporter: phlsa, Assigned: enndeakin)

References

Details

Attachments

(3 files)

When using RTL mode, the new arrowpanel animations have their origin on the wrong side.
Flags: firefox-backlog+
This is fairly simple. We just need to flip the transform-origins in rtl mode.
Assignee: nobody → enndeakin
Flags: needinfo?(mmucci)
Whiteboard: p=2 s=33.1
Added to Iteration 33.1

Neil, would you recommend this bug as [qa+] or [qa-] for verification?
Status: NEW → ASSIGNED
Flags: needinfo?(mmucci)
Whiteboard: p=2 s=33.1 → p=2 s=33.1 [qa?]
Attachment #8442946 - Flags: review?(dao)
Whiteboard: p=2 s=33.1 [qa?] → p=2 s=33.1 [qa+]
Iteration: --- → 33.2
Points: --- → 2
QA Whiteboard: [qa+]
Whiteboard: p=2 s=33.1 [qa+]
Comment on attachment 8442946 [details] [diff] [review]
Add rtl mode transform-origins

>--- a/toolkit/content/xul.css
>+++ b/toolkit/content/xul.css

>+panel[arrowposition="start_before"]:-moz-locale-dir(ltr) {
>   transform-origin: right 20px;
> }

>+panel[arrowposition="end_before"]:-moz-locale-dir(rtl) {
>+  transform-origin: right 20px;
>+}

>+panel[arrowposition="start_after"]:-moz-locale-dir(ltr) {
>   transform-origin: right calc(100% - 20px);
> }

>+panel[arrowposition="end_after"]:-moz-locale-dir(rtl) {
>+  transform-origin: right calc(100% - 20px);
> }

>+panel[arrowposition="end_before"]:-moz-locale-dir(ltr) {
>   transform-origin: left 20px;
> }

>+panel[arrowposition="start_before"]:-moz-locale-dir(rtl) {
>+  transform-origin: left 20px;
> }

>+panel[arrowposition="end_after"]:-moz-locale-dir(ltr) {
>   transform-origin: left calc(100% - 20px);
> }

>+panel[arrowposition="start_after"]:-moz-locale-dir(rtl) {
>+  transform-origin: left calc(100% - 20px);
>+}

These rules should be merged in pairs of two. (I reordered them to make my point.)
Attachment #8442946 - Flags: review?(dao) → review+
The change here for some reason changed the transition detection so a popup from an earlier test doesn't close properly. Fortunately, we have a proper way to detect whether a transition exists now. This patch just changes to use nsLayoutUtils::HasCurrentAnimations after a flush. The conditions are moved around to ensure that the flush is done is less circumstances.
Attachment #8442946 - Attachment is obsolete: true
Attachment #8447688 - Flags: review?(neil)
Try build now passes: https://tbpl.mozilla.org/?tree=Try&rev=b2b958947fa3
Iteration: 33.2 → 33.3
Comment on attachment 8447688 [details] [diff] [review]
Fix transition handling

Maybe someone else can review.
Attachment #8447688 - Flags: review?(mstange)
Comment on attachment 8447688 [details] [diff] [review]
Fix transition handling

I'm starting to catch up with reviews; sorry for the delay.

The patch context is sadly insufficient to include the start of the comment, where you assume that it has a closing transition. Now that you're actually checking rather than assuming, it would be nice of the comment could be fixed too :-)
Attachment #8447688 - Flags: review?(neil) → review+
Attachment #8447688 - Flags: review?(mstange)
Attachment #8442946 - Attachment is obsolete: false
https://hg.mozilla.org/mozilla-central/rev/1080f2330d51
https://hg.mozilla.org/mozilla-central/rev/c93d64f6a76a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Hi Florin, can a QA contact be assigned to this bug for verification.
Flags: needinfo?(florin.mezei)
Flags: needinfo?(florin.mezei)
QA Contact: cornel.ionce
I don't understand why this is being fixed while same issue reported for regular Firefox browser with menu button on the left side was marked as wontfix.

https://bugzilla.mozilla.org/show_bug.cgi?id=1032186
This bug affects people using the default build. That other bug does not.

That said, I think bug 1032186 would be fixed by 974389.
Hi Cornel, following up to see if this bug can be verified by Monday which is the end of the Desktop iteration.
Flags: needinfo?(cornel.ionce)
Thested on latest Firefox Nightly 33.0a1, build ID: 20140716030202 using the RTL builds (Ar, Fa, He, Ug and Ur) on the following OSs:
1. Windows 7 64bit - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
2. Ubuntu 14.04 32bit - Mozilla/5.0 (X11; Linux i686; rv:33.0) Gecko/20100101 Firefox/33.0
3. Mac OS X 10.9.4 - Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:33.0) Gecko/20100101 Firefox/33.0

The arrow-panel animations have their origin on their right side. Marking issue verified.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Flags: needinfo?(cornel.ionce)
Philipp found an issue here where the closing animation isn't correct from what it used to be. It shouldn't resize closed. He tested this patch and is ok with the result.
Attachment #8458728 - Flags: review?(dao)
Attachment #8458728 - Flags: review?(dao) → review+
This fixes up the comment as indicated by comment 10.

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c9ad40d8183
You need to log in before you can comment on or make changes to this bug.