Closed Bug 989991 Opened 6 years ago Closed 5 years ago

Add animation to PanelUI-popup

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 33

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

(Whiteboard: p=13 s=33.1 [qa!] [fixed by bug 994117])

There are issues with the size changing and scrollbars appearing when the animation is added, so it is currently turned off.

See bug 610545.
Maybe some guidance as to where this sizing is done or what code might be causing this.
Depends on: 610545
Flags: needinfo?(mconley)
Neil:

All of the dynamic sizing is done in the "panelmultiview" binding in browser/components/customizableui/content/panelUI.xml.

It's a bit of a hairy mess in there - but basically, we do a lot of listening for mutations in both the main views and subviews, and adjust the height of the container accordingly.
Flags: needinfo?(mconley)
Flags: firefox-backlog? → firefox-backlog+
Whiteboard: p=0
Whiteboard: p=0 → p=13
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Whiteboard: p=13 → p=13 s=it-32c-31a-30b.2 [qa?]
This bug is a little skimp in terms of specific use cases we can test, although bug 610545 has a good example. Qa+'ing to make sure we look at least that doorhanger and bookmarks panel animations, for example.
Whiteboard: p=13 s=it-32c-31a-30b.2 [qa?] → p=13 s=it-32c-31a-30b.2 [qa+]
The patch in bug 994117 will fix this.
Depends on: 994117
No longer depends on: 610545
Whiteboard: p=13 s=it-32c-31a-30b.2 [qa+] → p=13 s=it-32c-31a-30b.3 [qa+]
Duplicate of this bug: 1016187
Whiteboard: p=13 s=it-32c-31a-30b.3 [qa+] → p=13 s=33.1 [qa+]
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Whiteboard: p=13 s=33.1 [qa+] → p=13 s=33.1 [qa+] [fixed by bug 994117]
QA Contact: andrei.vaida
When menu button is on the left side of the window, animation is not being switched from right-to-left to left-to-right as other buttons do (you can check correct behavior with any other button like bookmarks or  history).

I know that firefox menu button cannot be moved to left side by default, but when you do (using addon) animation looks weird.
(In reply to Roman Müller from comment #7)
> When menu button is on the left side of the window, animation is not being
> switched from right-to-left to left-to-right as other buttons do (you can
> check correct behavior with any other button like bookmarks or  history).
> 
> I know that firefox menu button cannot be moved to left side by default, but
> when you do (using addon) animation looks weird.

This also happens in RTL mode => bug 1027057
This issue is verified fixed on Nightly 33 (2014-06-18) using: Windows 7 64-bit [1], Windows 8.1 64-bit [2], Ubuntu 13.10 64-bit [3] and Mac SO X 10.9.2 [4].

The following panels were checked for issues: site identity doorhanger, bookmarks panel, password manager doorhanger, downloads panel, geolocation doorhanger, mixed content blocker doorhanger, overflow panel, sidebars panel, loop panel and the CTP doorhanger. 

At this point, there were a few issues found involving two items:
* the already mentioned Bug 1027057 involving RTL mode
* a couple of issues involving Loop's button, but I'm not quite sure if this button implies a regular panel in the first place (?)
** intermittently, the Loop's panel is displayed as cutoff, see [5]
** Loop's button does not have an open icon state while its panel is displayed

What do you think?


[1] Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:33.0) Gecko/20100101 Firefox/33.0
[2] Mozilla/5.0 (Windows NT 6.3; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
[3] Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0
[4] Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:33.0) Gecko/20100101 Firefox/33.0
[5] http://goo.gl/nHZ0fX
Flags: needinfo?(enndeakin)
There is also an issue when you open the menu panel, then open a subview (developer for example). Close the panel and open it again quickly. The panel is then shrunk and shows a scrollbar.
(In reply to Guillaume C. [:ge3k0s] from comment #10)
> There is also an issue when you open the menu panel, then open a subview
> (developer for example). Close the panel and open it again quickly. The
> panel is then shrunk and shows a scrollbar.
Hi Guillaume, that's Bug 940733, if I'm not mistaken.
(In reply to Andrei Vaida, QA [:avaida] from comment #11)
> (In reply to Guillaume C. [:ge3k0s] from comment #10)
> > There is also an issue when you open the menu panel, then open a subview
> > (developer for example). Close the panel and open it again quickly. The
> > panel is then shrunk and shows a scrollbar.
> Hi Guillaume, that's Bug 940733, if I'm not mistaken.

That's another issue. Bug 940733 affects subviews. The issue I mentioned affects the main panel and appeared yesterday with the menu panel animation.
> * a couple of issues involving Loop's button, but I'm not quite sure if this
> button implies a regular panel in the first place (?)
> ** intermittently, the Loop's panel is displayed as cutoff, see [5]
> ** Loop's button does not have an open icon state while its panel is
> displayed

I'm not sure what that is, but they shouldn't have anything to do with this bug. Please file other bugs on those.
Flags: needinfo?(enndeakin)
(In reply to Neil Deakin from comment #13)
> I'm not sure what that is, but they shouldn't have anything to do with this
> bug. Please file other bugs on those.
I'll look further into those and file follow up bugs. Marking this issue verified fixed.

(In reply to Guillaume C. [:ge3k0s] from comment #12)
> That's another issue. Bug 940733 affects subviews. The issue I mentioned
> affects the main panel and appeared yesterday with the menu panel animation.
It would be great if you could file a bug on this matter as well, any additional details related to it would be appreciated.
Status: RESOLVED → VERIFIED
Whiteboard: p=13 s=33.1 [qa+] [fixed by bug 994117] → p=13 s=33.1 [qa!] [fixed by bug 994117]
Depends on: 1028519
Okay, WTF guys? This isn't in the release notes. And there doesn't seem to be a way to shut it off. Even Windows provides a way to shut off animations.

It would be one thing if it were a fade in, but it's a slide, which is visually jarring. And it's just slow enough to call attention to itself. Menu animations have been fade-ins for a long time for a reason.

I mean, it messes with my visual memory of where I've put everything, as I see items in a different location when I click the button. It's really rather jarring.

Please provide a way to disable this disruptive animation, at least until you can come up with one that is less jarring.
See Bug 984589 and Bug 1004870. Ignoring Windows menu effects settings that most other apps obey is bad behavior. Stop adding fancy animations that make Firefox inconsistent with the rest of the OS.
You need to log in before you can comment on or make changes to this bug.