1027175 - You can watch youtube videos even if Flash plugin is disabled. Plugincheck page need to be updated

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Emin Mastizada]

Attachment: plugincheck.lang

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140608211622

Steps to reproduce:

In mozorg/plugincheck.lang - string:
Caution: disabling a plugin means that you will no longer be able to do certain things. For example, if you disable Flash, you will not be able to watch videos on YouTube.

Already going to use different translation for my localization


Actual results:

Is it actual now when we have HTML5? I'm already using HTML5 in youtube and Firefox works more better and uses less memory.
As translation I wrote something like: If you disable Flash, you will not be able to watch some videos online (or most)


Expected results:

If this is not actual now, and we can play videos in youtube without Flash plugin, can this string be changed?

Comment 1

[Boris Zbarsky [:bzbarsky]]

This has nothing to do with text layout....

> Is it actual now when we have HTML5?

Yes.  Not all Youtube videos are available as HTML5 video, especially in browsers that are not shipping EME yet.

Comment 2

[Jennifer Bertsch [:jbertsch]]

Hello L10N Team -

Do you know if this an L10N bug or a plugin check bug?  

Thx,
Jen

Comment 3

[Théo Chevalier]

(In reply to Jennifer Bertsch [:jbertsch] from comment #2)
> Hello L10N Team -
> 
> Do you know if this an L10N bug or a plugin check bug?  
> 
> Thx,
> Jen

Hi Jen,

It seems we have to update the string in the en-US template: https://github.com/mozilla/bedrock/blob/master/bedrock/mozorg/templates/mozorg/plugincheck.html#L157

However, we have a couple options here:

- Adding a new l10n tag so that we can smoothly replace the old translation with the new one (But not sure if we want to display a translated string that's wrong until we get the new one translated, that could take some time for some locales)
- Temporarily disable the string for all locales, and enable it back once we get it translated. But we won't get any warning until we get translations.
- Just fix the string, so that the new string will appear fixed for all locales, but the string will be in English.

Comment 4

[Jennifer Bertsch [:jbertsch]]

(In reply to Théo Chevalier [:tchevalier] from comment #3)
> (In reply to Jennifer Bertsch [:jbertsch] from comment #2)
> > Hello L10N Team -
> > 
> > Do you know if this an L10N bug or a plugin check bug?  
> > 
> > Thx,
> > Jen
> 
> Hi Jen,
> 
> It seems we have to update the string in the en-US template:
> https://github.com/mozilla/bedrock/blob/master/bedrock/mozorg/templates/
> mozorg/plugincheck.html#L157
> 
> However, we have a couple options here:
> 
> - Adding a new l10n tag so that we can smoothly replace the old translation
> with the new one (But not sure if we want to display a translated string
> that's wrong until we get the new one translated, that could take some time
> for some locales)
> - Temporarily disable the string for all locales, and enable it back once we
> get it translated. But we won't get any warning until we get translations.
> - Just fix the string, so that the new string will appear fixed for all
> locales, but the string will be in English.

Hi Espressive-

Do you have a preference?

Thx,
Jen

Comment 5

[DJ-Leith]

(In reply to Théo Chevalier [:tchevalier] from comment #3)
> - Adding a new l10n tag so that we can smoothly replace the old translation with the
> new one (But not sure if we want to display a translated string that's wrong until
> we get the new one translated, that could take some time for some locales)

I agree that the wording about Youtube videos, Flash plugin and HTML5 is not ideal.

However, in my opinion, a harder to communicate and more *important* message that you
will soon be wishing to communicate is the issue that the Plugincheck service will
(soon) no longer inform the Users about "Unknown" plugins.

Since December 2013 I have been aware that 'this is coming' and I think it is
important to communicate it.

> ... smoothly replace the old translation ...
> ... we get the new one translated, that could take some time for some locales)

I am keen that those involved plan ahead as the 'loss of information about
"Unknown" plugins' is an important change to 'what Plugincheck can and can NOT do',
for the many Users who rely on this wonderful service.

BACKGROUND, with verbose introduction, links to other bugs and pictures see:
Bug 965812 "RFE an "About plugincheck" page, visible from plugincheck"


****** 
Time line
******

2010 August
The feature to display "Unknown" plugins has been 'part of the plugincheck service'
since August 2010.

See bug 573553 "Display 'unknown plugin' message for plugins not in db"
which was "Verified FIXED." on 2010-08-02.


2013 November 
Bug 757726 "disallow enumeration of navigator.plugins"
lands in Nightly.  I think this is an excellent change, to reduce fingerprinting.

However, it was anticipated that this would break plugincheck, see:
Bug 938885 "Fix plugincheck to not use plugin enumeration"
Schalk Neethling [:espressive] has been working on this since then.

2013 December
Plugincheck broken in Aurora, I first notice this (bug 938885 comment # 9).

2014-05-12
The JSON List (bug 956905) is now in production.
I have checked that, using Aurora
with NO enumeration - "plugins.enumerable_names" set to "" (empty string)
that 'plugincheck works'.  It does. There are some issues. There needs to be more QA.

See bug 956905 comment # 134 onwards.

Bug 1023718 comment # 10 for the outcome of 'bumping the new plugincheck service'
to STILL use enumeration in Fx 30.

DJ-Leith

Comment 6

[Schalk Neethling [:espressive]]

Hey Jen,

I would not say I have a strong preference but, I would go for fixing the string i.e.

- Just fix the string, so that the new string will appear fixed for all locales, but the string will be in English. (and over time it would be translated across all the locales) 

With that said, it would probably be a good idea to get someone like :flod input as well.

Comment 7

[Francesco Lodolo [:flod]]

I'm not a fan of English text displayed on a localized page, but in this case it's pretty hidden at the bottom of the page, so it shouldn't be a problem if we go with option 3 (fix English, get locales as soon as they're ready without adding tags).

For the record, in the Italian page "on YouTube" has been localized as "on some streaming video websites" for quite a while.

Comment 8

[Schalk Neethling [:espressive]]

(In reply to Francesco Lodolo [:flod] from comment #7)
> I'm not a fan of English text displayed on a localized page, but in this
> case it's pretty hidden at the bottom of the page, so it shouldn't be a
> problem if we go with option 3 (fix English, get locales as soon as they're
> ready without adding tags).
> 
> For the record, in the Italian page "on YouTube" has been localized as "on
> some streaming video websites" for quite a while.

Thanks Francesco, I reckon we should go with the same string as the Italian version.

Comment 9

[Jennifer Bertsch [:jbertsch]]

Alright, it looks like we have some consensus around "Just fix the string, so that the new string will appear fixed for all locales, but the string will be in English. (and over time it would be translated across all the locales)"

Espressive, is this something that you will do or should a mozilla.org web dev pick up the bug?


Thx,
Jen

Comment 10

[Schalk Neethling [:espressive]]

(In reply to Jennifer Bertsch [:jbertsch] from comment #9)
> Alright, it looks like we have some consensus around "Just fix the string,
> so that the new string will appear fixed for all locales, but the string
> will be in English. (and over time it would be translated across all the
> locales)"
> 
> Espressive, is this something that you will do or should a mozilla.org web
> dev pick up the bug?
> 
> 
> Thx,
> Jen

Taking it.

Comment 11

[Schalk Neethling [:espressive]]

Pull request: https://github.com/mozilla/bedrock/pull/2166

Comment 12

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/24b95f0c2e8e2e9a00acb8a6e54d9c43d60e9685
Fix Bug 1027175, change plugin disable text to reflect modern services

https://github.com/mozilla/bedrock/commit/c601406c1797b1664f33c48dfb5b1fafcf1b0e6c
Merge pull request #2166 from ossreleasefeed/bug1027175-update-plugincheck-page-text-flash-streaming

Fix Bug 1027175, change plugin disable text to reflect modern services