1027313 - [B2G][Contacts][Facebook]Removing all Facebook Data from device without other Contacts saved displays Delete Contacts button to select contacts that do not exist

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Montoya Clemmons (MClemmons)]

Attachment: Logcat Issue with deleted Facebook Contacts

User taps Contacts App and selects Settings to enable Facebook Sync friends without other Contacts saved on device. When user chooses to remove the Facebook data, the Delete Contacts button beneath Contacts Management is available even though there are none to select or deselect. 

Prerequisites:
1. Have Wi-Fi and/or Data Connection enabled
2. Have no Contacts saved
3. Sync Facebook friends to device within Contacts App 

Repro Steps:
1) Update a Flame to 20140618000202
2) Disable Sync friends in Contacts App 
3) Select Remove on Remove Data page
4) Select Delete Contacts from below Contacts Management 
5) Observe device behavior

Actual:
User taken to Contacts page that is without Contacts with a Select All and Deselect All button. 

Expected:
On screen message that there are no Contacts or the Delete Contacts button is disabled.

Environmental Variables:
Device: Flame 2.0
Build ID: 20140618000202
Gaia: 83844c7679b3b9f6e7f1116c1eeec2d1e7a64eec
Gecko: 55679dc2e72b
Version: 32.0a2 (2.0) 
Firmware Version: v121-2
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Repro frequency: (10/10, 100%, etc.)
Link to failed test case: None. This was found during exploratory testing around an existing test case. 
See attached: 
a) video clip = https://www.youtube.com/watch?v=xamWTLNpoM0
b) Flame logcat unavailable due to https://bugzilla.mozilla.org/show_bug.cgi?id=1010993
c) Open C logcat provided instead of Flame logcat described in b) above

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue DOES reproduce on Flame 2.1, Buri2.1, Open C 2.1, Flame 2.0, Buri 2.0, and Open C 2.0

Flame 2.1

Environmental Variables:
Device: Flame Master
Build ID: 20140618040513
Gaia: 431aed0a7c7560c6eacd35ea69aa0a7a4ebe72c7
Gecko: 37f08ddaea48
Version: 33.0a1 (Master) 
Firmware Version: v121-2
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0


Open_C 2.1

Environmental Variables:
Device: Open_C Master
Build ID: 20140618040513
Gaia: 431aed0a7c7560c6eacd35ea69aa0a7a4ebe72c7
Gecko: 37f08ddaea48
Version: 33.0a1 (Master) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0


Buri 2.1

Environmental Variables:
Device: Buri Master
Build ID: 20140618073003
Gaia: 336c30b6147cdd9122ad0b2bbffb81eb869a9ec2
Gecko: 1cea544c74c5
Version: 33.0a1 (Master) MOZ
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0


Buri 2.0

Environmental Variables:
Device: Buri 2.0
Build ID: 20140618063014
Gaia: 83844c7679b3b9f6e7f1116c1eeec2d1e7a64eec
Gecko: 883d156210cf
Version: 32.0a2 (2.0) MOZ
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Open_C 2.0

Environmental Variables:
Device: Open_C 2.0
Build ID: 20140618000202
Gaia: 83844c7679b3b9f6e7f1116c1eeec2d1e7a64eec
Gecko: 55679dc2e72b
Version: 32.0a2 (2.0) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

User taken to an empty Contacts page that has Select All and Deselect All buttons enabled. Tapping on them makes no change.
_________________________________________________________________________________________

This issue does NOT reproduce on Flame 1.4, Buri 1.4 or Open C 1.4

Buri 1.4

Environmental Variables:
Device: Buri 1.4
Build ID: 20140618063004
Gaia: fc74015d26bcbc3e31a45d34cb65777112a35982
Gecko: fab72d8aa2e0
Version: 30.0 (1.4) MOZ
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Flame 1.4

Environmental Variables:
Device: Flame 1.4
Build ID: 20140618000203
Gaia: 3bdd037ec1a11abebe16a5d7f6ff0d863e80bc07
Gecko: 523491fa3339
Version: 30.0 (1.4) 
Firmware Version: v121-2
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0


Open_C 1.4

Environmental Variables:
Device: Open_C 1.4
Build ID: 20140618000203
Gaia: 3bdd037ec1a11abebe16a5d7f6ff0d863e80bc07
Gecko: 523491fa3339
Version: 30.0 (1.4) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

The 'Delete Contacts' option and 'Contacts Management' section were not available on 1.4

Comment 2

[Jason Smith [:jsmith]]

Kevin - This is missing a branch analysis to see if this is a regression or not.

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

It was stated that this is not a regression in comment 1 because the 'Delete Contacts' option and 'Contacts Management' section were not available on 1.4.

Comment 4

[Jason Smith [:jsmith]]

(In reply to ktucker from comment #3)
> It was stated that this is not a regression in comment 1 because the 'Delete
> Contacts' option and 'Contacts Management' section were not available on 1.4.

Okay - if this is a new feature, then you need to make sure the component lead reviews the bug.

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

This is broken functionality of a new feature in contacts. Can you please take a look at this?

Comment 6

[KTucker [:KTucker][Inactive 3/4/2016]]

Loli can you please review this issue?

The "Delete Contacts" button is in an active state after removing all Facebook contacts from the phone if no other contacts are saved on the phone. This could confuse the end user because if they tap on "Delete Contacts", no contacts will be present but the user can still tap on "Select all and "Deselect all" which serves no purpose.

Comment 7

[Jason Smith [:jsmith]]

(In reply to ktucker from comment #6)
> Loli can you please review this issue?
> 
> The "Delete Contacts" button is in an active state after removing all
> Facebook contacts from the phone if no other contacts are saved on the
> phone. This could confuse the end user because if they tap on "Delete
> Contacts", no contacts will be present but the user can still tap on "Select
> all and "Deselect all" which serves no purpose.

Specifically, Kevin wants to know if you think this is a blocker for release.

Comment 8

[Loli (:lolimartinezcr)]

(In reply to Jason Smith [:jsmith] from comment #7)
> (In reply to ktucker from comment #6)
> > Loli can you please review this issue?
> > 
> > The "Delete Contacts" button is in an active state after removing all
> > Facebook contacts from the phone if no other contacts are saved on the
> > phone. This could confuse the end user because if they tap on "Delete
> > Contacts", no contacts will be present but the user can still tap on "Select
> > all and "Deselect all" which serves no purpose.
> 
> Specifically, Kevin wants to know if you think this is a blocker for release.

I have tested this bug in Hamachi (becausa Flame devices isn't available) and it is reproducible.

User can see "Contact Delete" screen with "Deselect all" and "Select all" buttons and "No contacts Start adding them now"  message

Tested
Hamachi
2.1
Gecko-af6ad08
Gaia-2863c6e

Comment 9

[Jason Smith [:jsmith]]

Loli - I don't think that answers what Kevin is trying to ask here. He's looking to know if you think this issue should block the release or not for 2.0.

Comment 10

[Loli (:lolimartinezcr)]

(In reply to Jason Smith [:jsmith] from comment #9)
> Loli - I don't think that answers what Kevin is trying to ask here. He's
> looking to know if you think this issue should block the release or not for
> 2.0.

I think this bug shouldn't be blocking, it really "does not break" anything.

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Loli from comment #10)
> (In reply to Jason Smith [:jsmith] from comment #9)
> > Loli - I don't think that answers what Kevin is trying to ask here. He's
> > looking to know if you think this issue should block the release or not for
> > 2.0.
> 
> I think this bug shouldn't be blocking, it really "does not break" anything.

Agree with this comment, also we are not leaking information from FB, so IMHO, is something to fix in 2.1 but not block 2.0

Comment 12

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

If the user has facebook or normal contacts in their contacts list, and then they Select "Delete Contacts" and then either "New Contacts" or "Settings" quickly, the "Select All" and "Deselect All" buttons will still appear. The user can then navigate through settings or new contacts pages like normal. 

This occurs on Flame 2.0 (512mb Memory, and 273mb Memory)

Flame 2.0

Environmental Variables:
Device: Flame 2.0
BuildID: 20140710000201
Gaia: 35a9b715e7348ec738ff6c8a59f50190390a06f2
Gecko: 94714370dfc3
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Attaching a video link to show results: http://youtu.be/oBTglO61sl0

Comment 13

[Adrián de la Rosa]

Attachment: 22144.html

Comment 14

[Jose Manuel Cantera]

Comment on attachment 8462412 [details]
22144.html

We need to simplify / improve the tests

Comment 15

[Adrián de la Rosa]

Comment on attachment 8462412 [details]
22144.html

Tests improved according with comments.

Comment 16

[Jose Manuel Cantera]

Comment on attachment 8462412 [details]
22144.html

thanks Adrian

Comment 17

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/f635281d98cd03f84359902e912633bd09faff5c

Comment 18

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1.

Result: "Delete Contacts" options is disabled after removing all Facebook contacts.

Device: Flame 2.1 (319mb, KK, Shallow Flash)
BuildID: 20141121001202
Gaia: 6c739275e963465658c18c7a9ebaa48cbe927d34
Gecko: 9bfc7a166a94
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0