1027391 - SIM lock shows a transparent status bar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2014-06-18-23-20-26.png

1. go to settings -> SIM manager -> sim security
2. turn sim pin on 
3. create a passcode
4. reboot phone
5. unlock screen to get to SIM Pin

Expected: black status bar
Actual: transparent status bar

Gaia      83844c7679b3b9f6e7f1116c1eeec2d1e7a64eec
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/55679dc2e72b
BuildID   20140618000202
Version   32.0a2
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014
Flame

Comment 1

[Jason Smith [:jsmith]]

UX clarified in a separate bug that any instance of a transparent status bar showing in a dialog was a blocker for visual refresh for 2.0, so noming this.

Comment 2

[Aus Lacroix [:aus]]

I'll have a look at this this afternoon.

Comment 3

[Aus Lacroix [:aus]]

Ugh! My SIM I got from IT already has a PIN set on it and I don't know what it is! Someone else should grab this in the meantime. :(

Comment 4

[Guillaume Marty [:gmarty]]

Attachment: Github PR

The events that open/close the sim pin dialog are listened and the status bar appearance is updated accordingly.

Etienne, can you have a look at this one?

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 8447235 [details]
Github PR

The sim pin dialog can be displayed on top of an app.

We should check that on simpinclose to make sure we're not making the statusbar transparent while the dialer is displayed for example.

Also, this change should be easily covered by tests :)

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8447235 [details]
Github PR

Almost there, and the tests are good.

But I think you still need to listen to the simpinopen event.
STR:
- On homescreen
- turn airplane mode on
- turn airplane mode off
- the sim dialog pops up but the status bar is still transparent

Comment 7

[Guillaume Marty [:gmarty]]

Comment on attachment 8447235 [details]
Github PR

I updated the code and tests to listen to simpinshow event and check this scenario is now OK.

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8447235 [details]
Github PR

The patch that keeps on giving :/

Okay, broken STR with the last version:
- skip the sim pin dialog the first time
- be at the top of the homescreen (transparent statusbar)
- open the dialer (black status bar + sim pin dialog)
- skip the sim pin dialog again (status bar still black)
- go back to the homescreen -> status bar black instead of transparent :/

This was a bit of a headscratcher, but basically when an app is active the status bar background will be black anyway.

So we need to *always* call  |this.setAppearance('semi-transparent');| when we get a simpinclose event.

This should fix all the scenarios and simplify the patch quite a bit.

Sorry for the earlier misinformation :/ Having a hard time wrapping my head around this part of the code.

Comment 9

[Guillaume Marty [:gmarty]]

Comment on attachment 8447235 [details]
Github PR

The latest version of the patch fixes this edge case.
Hope that'll be ok that time :-)

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8447235 [details]
Github PR

All good, congrats! This was harder than it looked :)

(PS: the patch needs rebasing, but it's an easy rebase)

Comment 11

[Guillaume Marty [:gmarty]]

Thanks Etienne! It's now rebased, waiting on Travis and Try.

Comment 12

[Guillaume Marty [:gmarty]]

Just merged in:
https://github.com/mozilla-b2g/gaia/commit/3c5a0ffdc81419b50b84e24e73bdaa0187c8ded6

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/16410831c2e513b5cabc550363f28a023dc256be

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Reverted from v2.0 for Gaia unit test failures.
v2.0: https://github.com/mozilla-b2g/gaia/commit/e935f4ff190b76c70d9b2af8856c542a6e4a7546

https://tbpl.mozilla.org/php/getParsedLog.php?id=43267991&tree=Mozilla-Aurora

Comment 15

[Guillaume Marty [:gmarty]]

I remove the declaration of |originalLocked| because it's not used in master, though it is in 2.0.

The updated PR is https://github.com/mozilla-b2g/gaia/pull/21491, waiting on Travis and Try.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Looks like this got merged to v2.0 already.
v2.0: https://github.com/mozilla-b2g/gaia/commit/4b7733d0a7a1efaffb4fd1540b1008afc83788bb

gmarty, please don't forget to mark the bugs when you land.