Closed
Bug 1027465
Opened 12 years ago
Closed 12 years ago
[settings] move root panel nfc item into panels/root
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S4 (20june)
People
(Reporter: gasolin, Assigned: gasolin)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
Current root panel related functions are loaded by LazyLoader and separate in settings/js, we should move NFC related item into panels/root and wrap with AMD pattern
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8442566 -
Flags: review?(arthur.chen)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8442566 [details] [review]
pull request redirect to github
Thanks for the patch, please check my comments in github.
Attachment #8442566 -
Flags: review?(arthur.chen)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 8442566 [details] [review]
pull request redirect to github
thanks for feedback! Removed .enabled and simplified the patch. please kindly review it again
Attachment #8442566 -
Flags: review?(arthur.chen)
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 8442566 [details] [review]
pull request redirect to github
r=me, thank you! Please also remove `apps/settings/js/nfc.js` from the xfail list.
Attachment #8442566 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
nfc.js remvoed from xfail list, merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/f2311f24a6e118b24e4f0107e060f7b9ee40584e
thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [p=1]
Target Milestone: --- → 2.0 S4 (20june)
You need to log in
before you can comment on or make changes to this bug.
Description
•