Closed Bug 1027478 Opened 7 years ago Closed 7 years ago

Modify telephony API from dialEmergency(number, serviceId) to dialEmergency(number)

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S6 (18july)

People

(Reporter: aknow, Assigned: rik)

References

Details

Attachments

(1 file)

We don't need to specify the serviceId. Gecko could automatically choose the proper one for the request.
Depends on: 1031239
In order to land the change smoothly, I suggest to separate it into 3 stages:

1. Gecko automatically select the sim card when dialing emergency call. 
   No interface change. The provided serviceId will be overwritten by gecko's choice.
   => Bug 1031239

2. Gaia modifies the usage of api. Ignore the argument of serviceId. Since this parameter is an optional field. It will not break the interface. Also, the behavior should be the same as stage 1.

3. Gecko modifies the interface. Remove parameter |serviceId|
   => this bug
Hi Anthony,

Step 1 is landed. It's time for gaia to remove the usage of 2nd parameter in dialEmergency(number, serviceId)
Flags: needinfo?(anthony)
Assignee: szchen → anthony
Status: NEW → ASSIGNED
Attachment #8458741 - Flags: review?(drs+bugzilla)
Flags: needinfo?(anthony)
Target Milestone: --- → 2.0 S6 (18july)
Comment on attachment 8458741 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/21935

I left one comment on the PR for a removal that I think was accidental.
Attachment #8458741 - Flags: review?(drs+bugzilla) → review+
Doh! Good catch!

https://github.com/mozilla-b2g/gaia/commit/3c56d1983f46d1d9dce509cdce02e207bce0df29
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Duplicate of this bug: 926345
Duplicate of this bug: 930866
You need to log in before you can comment on or make changes to this bug.