1031239 - Automatically select sim card for emergency call

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 1: Refactoring

Comment 2

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 2: select clientId for emergency call

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8447080 [details] [diff] [review]
Part 1: Refactoring

Review of attachment 8447080 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/gonk/TelephonyService.js
@@ +417,5 @@
>        aTelephonyCallback.notifyDialError(DIAL_ERROR_OTHER_CONNECTION_IN_USE);
>        return;
>      }
>  
> +    // We can only have at most two line on the same client.

nit: s/line/lines/

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8447081 [details] [diff] [review]
Part 2: select clientId for emergency call

Review of attachment 8447081 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/gonk/TelephonyService.js
@@ +370,5 @@
>      }
>      aListener.enumerateCallStateComplete();
>    },
>  
> +  // Automatically select a proper clinetId.

nit: s/clinetId/clientId

@@ +372,5 @@
>    },
>  
> +  // Automatically select a proper clinetId.
> +  // return -1 means none of the clients are available.
> +  _getClientForEmergencyCall: function() {

Expose to nsIRadioInterfaceLayer.idl as we discussed, thank you.

@@ +423,5 @@
>        aTelephonyCallback.notifyDialError(DIAL_ERROR_INVALID_STATE_ERROR);
>        return;
>      }
>  
> +    // Select a proper cliendId for dialEmergency.

nit:s/cliendId/clientId/

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 2#2: select clientId for emergency call

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8447910 [details] [diff] [review]
Part 2#2: select clientId for emergency call

Review of attachment 8447910 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thank you~

Comment 7

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [final] Part 1: Refactoring. r=hsinyi

Comment 8

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [final] Part 2: Select clientId for emergency call. r=hsinyi

Comment 9

[Szu-Yu Chen [:aknow] (inactive)]

https://tbpl.mozilla.org/?tree=Try&rev=092e0e5c97c1

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/1436162e1394
https://hg.mozilla.org/integration/b2g-inbound/rev/b3fc7fedfb65

In the future, please try to be more conscientious about what platforms and tests you run on your Try pushes (i.e. not running desktop/Android builds & tests on a B2G-only change). It saves a lot of resources and reduces the backlog felt by all developers when using Try. The link below gives some recommended practices if you need more assistance.
https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1436162e1394
https://hg.mozilla.org/mozilla-central/rev/b3fc7fedfb65