Automatically select sim card for emergency call

RESOLVED FIXED in 2.0 S5 (4july)

Status

Firefox OS
RIL
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aknow, Assigned: aknow)

Tracking

(Blocks: 1 bug)

unspecified
2.0 S5 (4july)
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8447080 [details] [diff] [review]
Part 1: Refactoring
Attachment #8447080 - Flags: review?(htsai)
(Assignee)

Comment 2

3 years ago
Created attachment 8447081 [details] [diff] [review]
Part 2: select clientId for emergency call
Attachment #8447081 - Flags: review?(htsai)
Comment on attachment 8447080 [details] [diff] [review]
Part 1: Refactoring

Review of attachment 8447080 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/gonk/TelephonyService.js
@@ +417,5 @@
>        aTelephonyCallback.notifyDialError(DIAL_ERROR_OTHER_CONNECTION_IN_USE);
>        return;
>      }
>  
> +    // We can only have at most two line on the same client.

nit: s/line/lines/
Attachment #8447080 - Flags: review?(htsai) → review+

Updated

3 years ago
Blocks: 959978
Comment on attachment 8447081 [details] [diff] [review]
Part 2: select clientId for emergency call

Review of attachment 8447081 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/gonk/TelephonyService.js
@@ +370,5 @@
>      }
>      aListener.enumerateCallStateComplete();
>    },
>  
> +  // Automatically select a proper clinetId.

nit: s/clinetId/clientId

@@ +372,5 @@
>    },
>  
> +  // Automatically select a proper clinetId.
> +  // return -1 means none of the clients are available.
> +  _getClientForEmergencyCall: function() {

Expose to nsIRadioInterfaceLayer.idl as we discussed, thank you.

@@ +423,5 @@
>        aTelephonyCallback.notifyDialError(DIAL_ERROR_INVALID_STATE_ERROR);
>        return;
>      }
>  
> +    // Select a proper cliendId for dialEmergency.

nit:s/cliendId/clientId/
Attachment #8447081 - Flags: review?(htsai)
(Assignee)

Comment 5

3 years ago
Created attachment 8447910 [details] [diff] [review]
Part 2#2: select clientId for emergency call
Attachment #8447081 - Attachment is obsolete: true
Attachment #8447910 - Flags: review?(htsai)
Comment on attachment 8447910 [details] [diff] [review]
Part 2#2: select clientId for emergency call

Review of attachment 8447910 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thank you~
Attachment #8447910 - Flags: review?(htsai) → review+
(Assignee)

Comment 7

3 years ago
Created attachment 8449320 [details] [diff] [review]
[final] Part 1: Refactoring. r=hsinyi
Attachment #8447080 - Attachment is obsolete: true
Attachment #8449320 - Flags: review+
(Assignee)

Comment 8

3 years ago
Created attachment 8449321 [details] [diff] [review]
[final] Part 2: Select clientId for emergency call. r=hsinyi
Attachment #8447910 - Attachment is obsolete: true
Attachment #8449321 - Flags: review+
(Assignee)

Comment 9

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=092e0e5c97c1
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/1436162e1394
https://hg.mozilla.org/integration/b2g-inbound/rev/b3fc7fedfb65

In the future, please try to be more conscientious about what platforms and tests you run on your Try pushes (i.e. not running desktop/Android builds & tests on a B2G-only change). It saves a lot of resources and reduces the backlog felt by all developers when using Try. The link below gives some recommended practices if you need more assistance.
https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1436162e1394
https://hg.mozilla.org/mozilla-central/rev/b3fc7fedfb65
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S5 (4july)
You need to log in before you can comment on or make changes to this bug.