1027480 - [contacts] Custom tag placeholder is not localized

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Théo Chevalier]

Attachment: Flame

Go to contacts, create a new contact, tap on a tag list for phone, e-mail...
"Custom tag" is not localized.

I don't understand why, because we already have "custom" and "custom.placeholder" strings in contact.properties, and it's using none of them.

You can notice that "Custom Tag" != "Custom tag", the former is the one in the HTML, the latter is in the l10n file.

When I flash gaia myself on top of the pvt build, I can read "Custom tag" instead of "Custom Tag", but it's still not localized.

Tested on both 2.0 and 2.1, Flame and Peak.

Flod, can you reproduce?

Comment 1

[Francesco Lodolo [:flod]]

I can definitely confirm on Master, trying to figure out the code behind it.

Comment 2

[Francesco Lodolo [:flod]]

The code is here
https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/elements/tag.html#L16

In the .properties file we have both "custom" and "custom.placeholder".

If I remove the "custom" label, the placeholder gets correctly localized.

Stas, any clue why this is happening?

Comment 3

[Staś Małolepszy :stas]

I remember Gandalf came across something like this in bug 992473 comment 58.  Is this bug a dupe of bug 1023608?

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

So, what happens here is that we have two l10n entities for two separate nodes with the same id "custom".

One is here: https://github.com/mozilla-b2g/gaia/blob/b0f74767bfb7e62c9cafca4b12b593b4912591ed/apps/communications/contacts/locales/contacts.en-US.properties#L47

Another is here: https://github.com/mozilla-b2g/gaia/blob/b0f74767bfb7e62c9cafca4b12b593b4912591ed/apps/communications/contacts/locales/contacts.en-US.properties#L80

How did it work before and how does it work right now, I have to say is beyond my understanding, but what I know is that if I change the latter to:

customTag.placeholder = Custom tag

and in https://github.com/mozilla-b2g/gaia/blob/b0f74767bfb7e62c9cafca4b12b593b4912591ed/apps/communications/contacts/elements/tag.html#L16

switch data-l10n-id to "customTag", then it fixes this bug.

Overall, the whole code around those cards nad customTag seems to be complex and prone to bugs (see bug 1023608 and bug 1023606), and I believe it needs some cleanup.

Comment 5

[Théo Chevalier]

Note that if we need to update entities, we need to get that landed on 2.0 by *tomorrow*

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Yup, we need this by tomorrow.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Quick hack until we get the whole thing really clean is to just fix the entity ID duplication.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ouch, I'm too fast!

[Approval Request Comment]
[Bug exposed by] : bug 914414
[User impact] if declined: untranslated string
[Risk to taking this patch] : none?
[String changes made]: duplicated custom -> custom.placeholder

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 8443277 [details] [review]
patch

Redirecting to a contact peer :)

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8443277 [details] [review]
patch

Thanks for the contribution.

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Landed:
https://github.com/mozilla-b2g/gaia/commit/7f022eaf3b7ee2b6f97198c56814327d5219a303

Comment 12

[Francesco Lodolo [:flod]]

Why are we removing "custom" instead of renaming "custom.placeholder" to "customTag.placeholder"? 
Is "custom" not used anymore?

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

Need a checkin to 2.0

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

[v2.0 7516172] Merge pull request #20780 from zbraniecki/1027480-new-entity-for-contacts-custom-tag