1027717 - Use a package manager to manage calendar app dependencies

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

Currently, we copy all of our dependencies which are developed outside of gaia into the gaia tree for lack of a better dependency management situation. We should take advantage of a nice, existing tool like npm, bower, or component to do the dependency management for us. We probably still have to check our node_modules/, bower_components/, or whatever else folder into source control since we have build and testing restrictions, but I think it's still a step in the right direction.

Since the way that many use bower is to

(1) distribute build artifacts like html / js binaries / css without extra library and test code and
(2) put artifacts in the top-level directory to make urls less complicated

I suggest bower. It's also quite popular amongst frontend people so many useful libraries are published in the bower registry.

Comment 1

[Gareth Aye [:gaye] (back from PTO)]

Would like to push ahead here and also with requirejs but want to make sure we have consensus :)

Comment 2

[James Lal [:lightsofapollo]]

Sounds good as long as we don't regress performance (I am sure we can improve it somehow with better rjs tooling)

Comment 3

[Miller Medeiros [:millermedeiros]]

I agree that having something (anything) would be good. I really like the simplicity and flexibility of volo[1] (by James Burke) since we can pick a single file and tell where it should be installed and the info is stored on the package.json. - I think it plays well with AMD and non-AMD code, for me it still feels weird to use npm to require code that is not written in the node.js module format. But I would be OK with any choice.

 [1] http://volojs.org/

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20771/files

Hey Miller,

I've gone ahead and packaged up our caldav and ical libraries for bower and registered them. node-uuid and page.js were already published in the registry. There's a lot of noise here, but largely not much has changed. I went ahead and updated the code in js/ and test/ to point to the new library locations.

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20816

Second try using volo which has a much smaller footprint on our project.

Comment 6

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8443627 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20816

volo FTW!

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/6da633c91af311cfea2cdb7e1926e86f946e4cab landed on master