1036753 - [Calendar] can't delete account

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

This is a regression introduced by the visual refresh.

Comment 1

[bhavana bajaj [:bajaj]]

Adding qawanted to help confirm the regression/branch checks and get the window here.

Comment 2

[Cody Roesch [:croesch]]

Hi Gareth,
   Could you provide me with a little more info on this bug?

-What steps did you take to get into this situation?
-What device was this seen on?
-What kind of calendar? (Offline, Google, Yahoo etc)
-What build and version were you using?

Any help on this is appreciated!

Comment 3

[Dylan Oliver [:doliver]]

triage: blocking for regression from 2.0 feature work

Comment 4

[Dylan Oliver [:doliver]]

Clearing qawanted, no need for a range here.

Comment 5

[Miller Medeiros [:millermedeiros]]

I just tried to reproduce this, steps:

 1) add a remote calendar (I tested with google calendar)
 2) open settings
 3) click the "gear icon"
 4) click account/calendar name
 5) click "remove local data"

expected:

 - It should delete the calendar and remove all the events from the current view.

actual result:

 - It did not delete the calendar.

Build info (Flame):

Gaia      46cd188fdda2397d2b8f3303a184dcd52952e2b2
Gecko     https://hg.mozilla.org/mozilla-central/rev/e032c429908b
BuildID   20140715040206
Version   33.0a1

---

I can't see anything wrong with `adb logcat | grep 'Gecko'` (even with debug flag). I'll keep investigating it but maybe I'll need a regression window.

Comment 6

[Miller Medeiros [:millermedeiros]]

regression was caused by Bug 1027717 (Use package manager in calendar) c9493a507dbaa288c8bdd11c1d9050443f804e9c is the first bad commit. Looks like the installed version of page.js is not compatible with our router logic. It was supposed to show a confirmation dialog after clicking the "remove local data" (which isn't happening).

will talk with Gareth about it but I think we should just use the old version of page.js since that was working well.. (already tested and confirmed that it fixes the problem)

git bisect FTW!

Comment 7

[Miller Medeiros [:millermedeiros]]

just confirmed that this doesn't happen on 2.0 (so it is not a blocker) and also found out that v1.3.2 of page.js works, so I'll submit a patch soon.

Comment 8

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21833

downgraded page.js to v1.3.2 and also fixed the node-uuid dependency name (we are storing it as "uuid.js" and not "node-uuid.js")

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21882

Added check for this to suite of tests already running against local radicale server. Wanted to use chai.assert.notInclude, but that didn't exist until 1.6.0, so went ahead and bumped our version from 1.4.x to 1.9.1. The check I added will, after an account is deleted from the calendar app, go ahead and hit the hamburger and make sure that it is no longer listed. Awesomely, the test failed on master but worked after being applied on top of the page.js downgrade.

Comment 10

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8458086 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21882

LGTM! tests are clean enough and should catch most common cases (confirm button not showing up and calendar not removed from list).

Comment 11

[Gareth Aye [:gaye] (back from PTO)]

Landed on master https://github.com/mozilla-b2g/gaia/commit/d33041e02c00be3f158765c84ef38deec3a90215

Comment 12

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8457406 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21833

removing review flag since it already landed on master.