Closed
Bug 1028250
Opened 10 years ago
Closed 10 years ago
[contacts] Remove unused strings custom.placeholder
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Firefox OS Graveyard
Gaia::Contacts
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S5 (4july)
People
(Reporter: flod, Assigned: flod)
Details
Attachments
(1 file)
https://bugzilla.mozilla.org/show_bug.cgi?id=1027480#c12 Did a grep on the the code but couldn't find anything related to "custom", besides what's fixed in bug 1027480. I was worried we used this "custom" in strange way, for example in contacts imported from GMail, but we're using "other" for custom tags. It should be safe to remove the extra string.
|
Assignee | |
Comment 1•10 years ago
|
||
This also fixes a markup error in /elements/form.html, and DOM used in tests (not actually used, but better to be consistent).
Attachment #8443528 -
Flags: review?(francisco)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8443528 [details] [review] Pull request on Github Thnks Francesco.
Attachment #8443528 -
Flags: review?(francisco) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Green Travis https://travis-ci.org/mozilla-b2g/gaia/builds/28054289
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/6b1daab3b41acab92e054f50f5b7585976f0985d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S5 (4july)
|
|
||
Updated•10 years ago
|
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•